From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id AB6F16DE0B00
 for <notmuch@notmuchmail.org>; Thu, 20 Oct 2016 16:45:04 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.006
X-Spam-Level: 
X-Spam-Status: No, score=-0.006 tagged_above=-999 required=5 tests=[AWL=0.005, 
 SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id CC6M8sq0XCHo for <notmuch@notmuchmail.org>;
 Thu, 20 Oct 2016 16:45:04 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id 25D0F6DE0AF4
 for <notmuch@notmuchmail.org>; Thu, 20 Oct 2016 16:45:04 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)
 (envelope-from <david@tethera.net>)
 id 1bxN0w-00011n-4w; Thu, 20 Oct 2016 19:44:46 -0400
Received: (nullmailer pid 20469 invoked by uid 1000);
 Thu, 20 Oct 2016 23:45:00 -0000
From: David Bremner <david@tethera.net>
To: Franz Fellner <alpine.art.de@gmail.com>, Tomi Ollila <tomi.ollila@iki.fi>,
 notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: Re: [PATCH] lib/database.cc: fix misleading indentation
In-Reply-To: <1.476.988.252-ner-1.022@TP_L520>
References: <1474988812-21365-1-git-send-email-tomi.ollila@iki.fi>
 <1.476.968.079-ner-1.779@TP_L520> <87funrrmqb.fsf@tesseract.cs.unb.ca>
 <1.476.988.252-ner-1.022@TP_L520>
Date: Thu, 20 Oct 2016 20:45:00 -0300
Message-ID: <87h986k2kj.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Oct 2016 23:45:04 -0000

Franz Fellner <alpine.art.de@gmail.com> writes:

> From a quick visual scan at least half the indented lines start with 4 spaces
> instead of TABS. As I understand the quoted paragraph that should be wrong.
>

Can you be specific what what lines in what file? I have the feeling
you're misinterpreting something, or looking at a different file.

>> that _should_ be enforced by devel/uncrustify.cfg
>
> When was uncrustify used the last time? I simply ran it on lib/database.cc and
> it produced a diff with 661 lines - the leading spaces were NOT fixed ;)
>

No idea if it was ever done globally. But I'm also not sure which
leading spaces you are talking about.

d