unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Cc: Tomi Ollila <tomi.ollila@iki.fi>
Subject: Re: [PATCH 5/7] emacs: hello: require cl
Date: Sat, 11 Mar 2017 11:01:39 -0400	[thread overview]
Message-ID: <87h92zrh64.fsf@tethera.net> (raw)
In-Reply-To: <1399797282-20389-6-git-send-email-markwalters1009@gmail.com>

Mark Walters <markwalters1009@gmail.com> writes:
>  
> -(eval-when-compile (require 'cl))
> +(require 'cl)
>  (require 'widget)
>  (require 'wid-edit) ; For `widget-forward'.
>  
> @@ -1017,3 +1017,7 @@ (defun notmuch-folder ()
>  ;;
>  
>  (provide 'notmuch-hello)
> +
> +;; Local Variables:
> +;; byte-compile-warnings: (not cl-functions)
> +;; End:

I was wondering if we should make any attempt to use cl-lib instead of
cl.el, since the former is more supported in newer emacs (e.g. allowed
for use in core code, I think). On the other hand, maybe it just causes
problems with emacs 23 (which we haven't completely dropped yet)

  reply	other threads:[~2017-03-11 15:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-11  8:34 [PATCH 0/7] emacs: hello: custom display of saved searches Mark Walters
2014-05-11  8:34 ` [PATCH 1/7] emacs: hello: separate out the saved-search display function Mark Walters
2017-03-11 14:57   ` David Bremner
2014-05-11  8:34 ` [PATCH 2/7] emacs: hello: allow saved search display functions Mark Walters
2014-05-12 14:03   ` David Edmondson
2014-05-12 15:20     ` Mark Walters
2014-05-11  8:34 ` [PATCH 3/7] emacs: hello: store previous saved-search results Mark Walters
2014-05-11  8:34 ` [PATCH 4/7] emacs: hello: add a threads-and-messages function Mark Walters
2014-05-11  8:34 ` [PATCH 5/7] emacs: hello: require cl Mark Walters
2017-03-11 15:01   ` David Bremner [this message]
2014-05-11  8:34 ` [PATCH 6/7] emacs: hello: add highlight newly arrived messages option Mark Walters
2014-05-12 13:58   ` David Edmondson
2014-05-12 15:33     ` Mark Walters
2016-01-07 22:52   ` Tomi Ollila
2014-05-11  8:34 ` [PATCH 7/7] emacs: hello: add option to omit count for a search Mark Walters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h92zrh64.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).