From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: David Bremner <david@tethera.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: debian packaging cleanup
Date: Thu, 30 Nov 2017 09:57:46 -0500 [thread overview]
Message-ID: <87h8tb4xw5.fsf@fifthhorseman.net> (raw)
In-Reply-To: <87d140vuup.fsf@tethera.net>
On Thu 2017-11-30 08:01:18 -0400, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>> The following patch series should be fairly unobjectionable cleanup of
>> the debian packaging for notmuch.
>>
>> Let me know if you think there are problems with any of it.
>
> Not problems per se, but I would expect several of these things to be
> documented in debian/changelog, including the standards version change.
I was presuming to do one rollup patch to build out the debian/changelog
entry as release time approaches, rather than including changelog
messages in the patches themselves.
That rollup patch should be fairly easy to do with, e.g.:
gbp dch --new-version=0.26-1 debian/
I prefer this approach because:
(a) it doesn't confuse changelog messages with patches, and
(b) it means that we don't end up with heavily-ordered patches, where
it's more difficult merge some patches from a series than others,
because each patch to d/changelog depends on the immediately prior
changeset.
I'd much rather you (or anyone else reviewing) can immediately and
trivially pull the changes you like from the series while leaving the
ones you're less certain about unmerged, for further discussion.
Case in point here, the change to python3-sphinx might be more
problematic than i'd originally expected. I wouldn't want anyone to
have to rewrite the subsequent trivial patches just to leave that one
behind.
Is there a reason to prefer patching d/changelog in each individual
changeset?
--dkg
next prev parent reply other threads:[~2017-11-30 14:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 9:40 debian packaging cleanup Daniel Kahn Gillmor
2017-11-30 9:40 ` [PATCH 1/5] debian/control: build-depend on python3-sphinx instead of python-sphinx Daniel Kahn Gillmor
2017-11-30 14:25 ` Daniel Kahn Gillmor
2017-12-03 13:35 ` Tomi Ollila
2017-12-04 14:30 ` Daniel Kahn Gillmor
2017-12-04 20:58 ` Tomi Ollila
2017-12-04 21:12 ` Tomi Ollila
2017-12-06 1:46 ` [PATCH v2] " Daniel Kahn Gillmor
2017-12-07 12:31 ` David Bremner
2017-11-30 9:40 ` [PATCH 2/5] debian/changelog: remove trailing whitespace Daniel Kahn Gillmor
2017-11-30 9:40 ` [PATCH 3/5] debian/control: Priority: extra is deprecated Daniel Kahn Gillmor
2017-11-30 9:40 ` [PATCH 4/5] debian: bump Standards-Version to 4.1.1 Daniel Kahn Gillmor
2017-12-05 1:30 ` David Bremner
2017-12-05 17:13 ` Daniel Kahn Gillmor
2017-11-30 9:40 ` [PATCH 5/5] debian/control: put elpa-notmuch in Section: lisp Daniel Kahn Gillmor
2017-12-07 14:23 ` Daniel Kahn Gillmor
2017-11-30 12:01 ` debian packaging cleanup David Bremner
2017-11-30 14:57 ` Daniel Kahn Gillmor [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-10 17:37 Debian " Daniel Kahn Gillmor
2019-11-12 15:47 ` Antoine Beaupré
2019-11-21 2:38 ` Daniel Kahn Gillmor
2019-11-21 12:08 ` David Bremner
2019-11-21 20:35 ` Daniel Kahn Gillmor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8tb4xw5.fsf@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).