From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Antoine Amarilli <a3nm@a3nm.net>, notmuch@notmuchmail.org
Subject: Re: Bug?: manpages are only readable by root when doing sudo make install with umask 077
Date: Wed, 10 Jan 2018 15:40:13 -0500 [thread overview]
Message-ID: <87h8rt30sy.fsf@fifthhorseman.net> (raw)
In-Reply-To: <20180110182959.nci4wukse5y4yvot@zeta>
Hi Antoine--
On Wed 2018-01-10 19:29:59 +0100, Antoine Amarilli wrote:
> On Wed, Jan 10, 2018 at 11:23:03AM -0500, Daniel Kahn Gillmor wrote:
> That's right. Looking more closely I think the issue is only with the
> permissions of the directories /usr/local/share/man/man*, not the files
> that they contain. Of course this is still an obstacle for the manpages
> to be readable. So I guess the following in doc/Makefile.local (just
> above what you quoted):
>
> mkdir -p "$(DESTDIR)$(mandir)/man1"
> mkdir -p "$(DESTDIR)$(mandir)/man5"
> mkdir -p "$(DESTDIR)$(mandir)/man7"
>
> does not override the umask. I suspect that the parameter -m0644 should
> be passed to these invocations too.
That sounds about right, though i think you want -m0755, since the
directories need the executable bit set to be traversable.
Would you try this out (probably have to remove the existing directories
first to test it, assuming that there's nothing there from anything
other than notmuch), and then send a patch directly to the mailing list?
thanks for your attention to detail here, it's the best way to make
things work for everyone in the future :)
--dkg
next prev parent reply other threads:[~2018-01-10 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 15:38 Bug?: manpages are only readable by root when doing sudo make install with umask 077 Antoine Amarilli
2018-01-10 16:23 ` Daniel Kahn Gillmor
2018-01-10 18:29 ` Antoine Amarilli
2018-01-10 19:45 ` Tomi Ollila
2018-01-10 20:41 ` Daniel Kahn Gillmor
2018-01-10 20:40 ` Daniel Kahn Gillmor [this message]
2018-01-31 20:31 ` Antoine Amarilli
2018-01-31 20:50 ` [PATCH] doc: create manpage folders with right permissions Antoine Amarilli
2018-01-31 20:56 ` Daniel Kahn Gillmor
2018-02-01 11:22 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8rt30sy.fsf@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=a3nm@a3nm.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).