From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: David Bremner <david@tethera.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 11/20] cli/show: emit payload subject instead of outside subject
Date: Fri, 13 Jul 2018 16:29:19 -0400 [thread overview]
Message-ID: <87h8l2hobk.fsf@fifthhorseman.net> (raw)
In-Reply-To: <87a7ree87v.fsf@tethera.net>
On Thu 2018-06-28 21:40:04 -0300, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>>
>> sp->map_key (sp, "Subject");
>> - sp->string (sp, g_mime_message_get_subject (message));
>> + if (msg_crypto && msg_crypto->payload_subject) {
>> + sp->string (sp, msg_crypto->payload_subject);
>> + } else
>> + sp->string (sp, g_mime_message_get_subject (message));
>
> This is not really an issue with your patch per se, but do we actually
> use this code for anything other than top level messages? I'm wondering
> because of my experiments with storing message-document level headers
> [1]. It seems difficult to look at the database when things are done at
> the GMime level like this.
>
> [1] id:20180623014247.17834-1-david@tethera.net
hm, we might be also using this code (format_headers_sprinter() in
notmuch-show.c) for attached/forwarded messages. what i wouldn't want
to happen is for an internal message to get its subject swapped out for
the top-level message's subject!
In the new draft of this series, i'm creating an
encrypted-message-with-forwarded-attachment to try to ensure that this
isn't a problem. thanks for raising the issue.
--dkg
next prev parent reply other threads:[~2018-07-14 0:03 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 5:55 Protected headers in notmuch Daniel Kahn Gillmor
2018-05-11 5:55 ` [PATCH 01/20] test: new test framework to compare json parts Daniel Kahn Gillmor
2018-06-06 1:06 ` David Bremner
2018-06-06 14:49 ` Daniel Kahn Gillmor
2018-06-06 16:21 ` David Bremner
2018-06-06 20:18 ` Daniel Kahn Gillmor
2018-06-07 8:39 ` Tomi Ollila
2018-05-11 5:55 ` [PATCH 02/20] crypto: Avoid pretending to verify signatures on unsigned encrypted mail Daniel Kahn Gillmor
2018-05-11 5:55 ` [PATCH 03/20] cli/show: pass the siglist directly to the sigstatus sprinter Daniel Kahn Gillmor
2018-05-11 5:55 ` [PATCH 04/20] util/crypto: _notmuch_message_crypto: tracks message-wide crypto state Daniel Kahn Gillmor
2018-06-15 10:16 ` David Bremner
2018-06-28 21:15 ` Daniel Kahn Gillmor
2018-05-11 5:55 ` [PATCH 05/20] cli: expose message-wide crypto status from mime-node Daniel Kahn Gillmor
2018-05-11 5:55 ` [PATCH 06/20] mime-node: track whole-message crypto state while walking the tree Daniel Kahn Gillmor
2018-06-15 10:52 ` David Bremner
2018-05-11 5:55 ` [PATCH 07/20] cli/show: emit new whole-message crypto status output Daniel Kahn Gillmor
2018-06-15 23:47 ` David Bremner
2018-06-29 15:41 ` Daniel Kahn Gillmor
2018-06-29 15:46 ` David Bremner
2018-05-11 5:55 ` [PATCH 08/20] cli/show: emit headers after emitting body Daniel Kahn Gillmor
2018-06-16 0:30 ` David Bremner
2018-05-11 5:55 ` [PATCH 09/20] util/crypto: add information about the payload part Daniel Kahn Gillmor
2018-06-25 1:15 ` David Bremner
2018-06-30 2:05 ` Daniel Kahn Gillmor
2018-05-11 5:55 ` [PATCH 10/20] cli/show: add tests for viewing protected headers Daniel Kahn Gillmor
2018-06-25 1:31 ` David Bremner
2018-06-30 2:17 ` Daniel Kahn Gillmor
2018-05-11 5:55 ` [PATCH 11/20] cli/show: emit payload subject instead of outside subject Daniel Kahn Gillmor
2018-06-29 0:40 ` David Bremner
2018-07-13 20:29 ` Daniel Kahn Gillmor [this message]
2018-05-11 5:55 ` [PATCH 12/20] cli/show: add information about which headers were protected Daniel Kahn Gillmor
2018-06-29 0:58 ` David Bremner
2018-05-11 5:55 ` [PATCH 13/20] test: add test for missing external subject Daniel Kahn Gillmor
2018-05-11 5:55 ` [PATCH 14/20] test: show cryptographic envelope information for signed mails Daniel Kahn Gillmor
2018-06-29 11:38 ` David Bremner
2018-05-11 5:55 ` [PATCH 15/20] cli/reply: ensure encrypted Subject: line does not leak in the clear Daniel Kahn Gillmor
2018-05-11 5:55 ` [PATCH 16/20] cli: introduce flags for format_headers_sprinter Daniel Kahn Gillmor
2018-05-11 5:55 ` [PATCH 17/20] cli/reply: add --protected-subject boolean flag Daniel Kahn Gillmor
2018-06-29 11:51 ` David Bremner
2018-05-11 5:55 ` [PATCH 18/20] indexing: record protected subject when indexing cleartext Daniel Kahn Gillmor
2018-06-02 17:59 ` Jameson Graef Rollins
2018-05-11 5:55 ` [PATCH 19/20] test: protected headers should work when both encrypted and signed Daniel Kahn Gillmor
2018-05-11 5:55 ` [PATCH 20/20] test: after reindexing, only legitimate protected subjects are searchable Daniel Kahn Gillmor
2018-06-02 18:25 ` Protected headers in notmuch Jameson Graef Rollins
2018-06-02 19:20 ` David Bremner
2018-06-03 13:44 ` Daniel Kahn Gillmor
2018-06-06 1:10 ` David Bremner
2018-06-03 18:14 ` Jameson Graef Rollins
2018-07-25 6:01 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8l2hobk.fsf@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).