From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 5D7AE6DE10C5 for ; Wed, 1 May 2019 13:37:39 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.032 X-Spam-Level: X-Spam-Status: No, score=-0.032 tagged_above=-999 required=5 tests=[AWL=-0.031, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FzfntKj-mZlZ for ; Wed, 1 May 2019 13:37:38 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id C46536DE10B6 for ; Wed, 1 May 2019 13:37:38 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1hLvz0-0004B0-12; Wed, 01 May 2019 16:37:38 -0400 Received: (nullmailer pid 5268 invoked by uid 1000); Wed, 01 May 2019 20:37:36 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] build: drop support for gmime-2.6 In-Reply-To: References: <20190501104643.5836-1-david@tethera.net> Date: Wed, 01 May 2019 17:37:36 -0300 Message-ID: <87h8adnc6n.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 May 2019 20:37:39 -0000 Tomi Ollila writes: >> -# we need to have a version >= 2.6.5 to avoid a crypto bug. We need >> -# 2.6.7 for permissive "From " header handling. >> -GMIME_MINVER=2.6.7 >> GMIME3_MINVER=3.0.3 > > This series looks good, but why change GMIME_MINVER to GMIME3_MINVER ? > Both existed before, and I just dropped one. It helped catch a few places where GMIME_MINVER was still used. But maybe you're right, maybe that's too lazy. d