From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id C75876DE0F31 for ; Tue, 21 May 2019 18:56:51 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.037 X-Spam-Level: X-Spam-Status: No, score=-0.037 tagged_above=-999 required=5 tests=[AWL=-0.036, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mP2QpGnMUMaS for ; Tue, 21 May 2019 18:56:50 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 2F8C46DE0F18 for ; Tue, 21 May 2019 18:56:49 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1hTGUo-0003BT-SU; Tue, 21 May 2019 21:56:46 -0400 Received: (nullmailer pid 32494 invoked by uid 1000); Wed, 22 May 2019 01:56:50 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Cc: tomi.ollila@iki.fi Subject: Re: [PATCH] test: redirect STDIN from /dev/tty In-Reply-To: <20190521201702.28754-1-tomi.ollila@iki.fi> References: <20190521201702.28754-1-tomi.ollila@iki.fi> Date: Tue, 21 May 2019 22:56:50 -0300 Message-ID: <87h89ntfod.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 May 2019 01:56:51 -0000 Tomi Ollila writes: > Without this stdin may be anything that parent process provided for it. > > Test processes might have tried to read something from it, which would > have caused undeterministic behavior. > > E.g. gdb(1) tries to do tty related ioctls on fd 0 (and fd 1 and fd 2, > but those are redirected to 'test.output' before test runs). > --- > > Hopefully this fixes the parallel problems -- In case of moreutils parallel > only stdout and stderr are captured and all other fd's left untouched > (provided I read web namual correctly). With GNU parallel docs did not > help -- but as we pipe $TESTS to parallel in that case things might be > even more complicated there (i don't undersand why but anyway) I can confirm that this seems to fix the parallel test problems with moreutils parallel and GNU. I think I'm leaning towards this fix between the two, but I'll sleep on it and decide tommorow. d