From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 5F35B6DE0246 for ; Thu, 21 Nov 2019 13:43:38 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -2.774 X-Spam-Level: X-Spam-Status: No, score=-2.774 tagged_above=-999 required=5 tests=[AWL=-1.872, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B_XdPxlKsi_l for ; Thu, 21 Nov 2019 13:43:37 -0800 (PST) X-Greylist: delayed 350 seconds by postgrey-1.36 at arlo; Thu, 21 Nov 2019 13:43:37 PST Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by arlo.cworth.org (Postfix) with ESMTPS id 5AFEC6DE0245 for ; Thu, 21 Nov 2019 13:43:37 -0800 (PST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 07FB522B44; Thu, 21 Nov 2019 16:37:46 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 21 Nov 2019 16:37:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:date:message-id:mime-version:content-type; s=fm1; bh=5eXIKFlijB629/4kRilvv0Ok72pyVDNK2Od5VnLkuOw=; b=DI7eS Z27p0eCk5mBMHtSEPz4kjTecevYJVZ6YEpMzSMQOT6AnVjOimLzTCTtJ6Tlaqks4 R2WZSu6JTye39RE2JVZf0cn2Ph+U+Ap0oVygtkJPKSl84t+3jAaPhNIAd30CCmMP hileB/4hH//SJ1mYesEgdkX7gw+YwO9afYo8Ya5XFpZuoheKMYrBuu29Jt3Gy5wL aV7lJw6ycdIojE9LFiGnNw74yWFFrRIwpwHmlmnbMgIlI6tObKOaTEdS+GHbQ+MF s3IFxpO4hlIzIaKXxJfWzPeQUoeVUTFoTBbuj0humofobJ6o7R3EsCoFWS1ue4/v coJODf6oi7tczqDpw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=5eXIKFlijB629/4kRilvv0Ok72pyV DNK2Od5VnLkuOw=; b=WOVsSeqJItVSKIOK8JdqDDWRxoUNsctRKlOwNLsnvIQcM ktBSjmXcHrAiTpoHihUJxmX5yMjTm5FWn5iOPaotCPHk3vEkhJpx1laSn61pKIcA HFen5vA0ktnpozqHjK+ardFxXvlb719uk00iNifrX/ZYRJfYYhtLf9/GFpzVdyRm +Q3a0zdG/dvpnYfxjK8McsS8cJVBvCEt9mtg68DG8rSac11Sq9kHbRrrgTYwpViB GYz7FO8kXvAK8QXavI+Vu82ohB1rRURHDRRZWTuXOF6YonOynNdXiSQ+cutIMQ7f EFD+QR6a5qYhAmvVOHGMkycWaLdhNgrs+CEhzWhVg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudehvddgudehfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfggtgesthdtredttd dttdenucfhrhhomhepufgvrghnucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhp fihhihhtthhonhdrnhgrmhgvqeenucffohhmrghinhepvhgrrhhirggslhgvrdhorhhgne curfgrrhgrmhepmhgrihhlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhn rdhnrghmvgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: From: Sean Whitton To: emacs-orgmode@gnu.org Cc: notmuch@notmuchmail.org Subject: Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query Date: Thu, 21 Nov 2019 14:37:44 -0700 Message-ID: <87h82wrjvb.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2019 21:43:38 -0000 Dear maintainers, The function `org-notmuch-follow-link' in {org,ol}-notmuch.el calls `notmuch-show' with an arbitrary notmuch search query. However, the docstring for `notmuch-show' specifies that a notmuch thread ID, rather than an arbitrary notmuch query, should be supplied to `notmuch-show'. The effect of this is that the variable `notmuch-show-thread-id' may contain an arbitrary search query rather than a thread ID. That broke some code of mine which uses that variable. `org-notmuch-follow-link' needs to continue to accept an arbitrary query (as notmuch thread IDs are not stable), but it should convert it to a thread ID before passing it to `notmuch-show'. -- Sean Whitton