From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jb55@jb55.com>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 72B386DE10AA
 for <notmuch@notmuchmail.org>; Wed,  4 Dec 2019 11:18:12 -0800 (PST)
Authentication-Results: arlo.cworth.org; dkim=pass (2048-bit key;
 secure) header.d=jb55.com header.i=@jb55.com header.b="BBF5oL5Z"; 
 dkim-atps=neutral
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.364
X-Spam-Level: 
X-Spam-Status: No, score=-0.364 tagged_above=-999 required=5
 tests=[AWL=-0.164, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
 DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id ujK0nQ-MeXMH for <notmuch@notmuchmail.org>;
 Wed,  4 Dec 2019 11:18:11 -0800 (PST)
Received: from jb55.com (jb55.com [45.79.91.128])
 by arlo.cworth.org (Postfix) with ESMTPS id A798F6DE1055
 for <notmuch@notmuchmail.org>; Wed,  4 Dec 2019 11:18:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d= jb55.com;
 h=from:to:subject:date:message-id; s=default;
 bh=szXAvXLSwb+dezWdwanD9x7vWcprQpSeU5Ci2dv+nK4=;
 b=BBF5oL5ZEic9x3vhZLARi8lj2thXdBWX+4gh+YmR8b+TPcp/GyrVVg18tOh+hIIeeUKvjwd0h9R/a89jWvLnHDSXOKMht3nmQn1jIaa+03ZtawOA+F2rwTH29FqoHgGPIedHh4IfHLXaAsPTBwmVeCj8zCvONej9gAWqdCgmbv7ggCleJwIyNaBPA23o7yT4obO+ZD3dXseJBZ+gG8QiTecSvmdqT8obl/5lv9yDnXJLhtWAnMnJ06GUfkCGEPOZEc+2rkyH5aoa3XQ8PlQ+n2+p4M3Weqa2ZLFBJ3g/ybKccKgsdUET2W1V+RekeiifUww6g8OPWDyuCH/+b2K7GA==
Received: from jb55.com (S010660e327dca171.vc.shawcable.net [24.84.152.187])
 by jb55.com (OpenSMTPD) with ESMTPSA id 059e0bb7
 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; 
 Wed, 4 Dec 2019 19:18:10 +0000 (UTC)
From: William Casarin <jb55@jb55.com>
To: Teemu Likonen <tlikonen@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 0/8] Port notmuch-show's x/X bindings to notmuch-tree
In-Reply-To: <87k17cauth.fsf@iki.fi>
References: <20191128161401.28844-1-jb55@jb55.com> <87k17cauth.fsf@iki.fi>
Date: Wed, 04 Dec 2019 11:18:10 -0800
Message-ID: <87h82frjbh.fsf@jb55.com>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Dec 2019 19:18:12 -0000

Teemu Likonen <tlikonen@iki.fi> writes:

> William Casarin [2019-11-28T08:13:53-08] wrote:
>
>> These patches bring notmuch-tree more in line with the user experience
>> of notmuch-show by adding the x/X bindings.
>>
>> v2:
>>   - fix a bug when moving between open messages
>>   - include M-RET keybinding patch from id:20191113225752.26502-1-jb55@jb55.com
>
> A minor inconvenience: In "show" mode X key
> (notmuch-show-archive-thread-then-exit) archives, exits and moves the
> cursor above the next thread in the list. In "tree" mode this new X key
> (notmuch-tree-archive-thread-then-exit) does not move the cursor to the
> next thread.

I didn't even realize notmuch-show does this, I never noticed it before.
I'll see if there's a quick fix.

Another thing I noticed is that X won't work if it moves past the last
message. This is a minor inconvenience, perhaps I can make it so it
doesn't move down a line if there are no more messages.