From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mNeNNL6yXl/vZAAA0tVLHw (envelope-from ) for ; Mon, 14 Sep 2020 00:01:02 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 0GzkLr6yXl/QQAAA1q6Kng (envelope-from ) for ; Mon, 14 Sep 2020 00:01:02 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8824194060D for ; Sun, 13 Sep 2020 23:56:02 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id BF9912931D; Sun, 13 Sep 2020 19:55:54 -0400 (EDT) Received: from smtprelay.hostedemail.com (smtprelay0138.hostedemail.com [216.40.44.138]) by mail.notmuchmail.org (Postfix) with ESMTPS id C140227B6D for ; Sun, 13 Sep 2020 19:55:50 -0400 (EDT) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 400A7182CED2A; Sun, 13 Sep 2020 23:55:47 +0000 (UTC) X-Session-Marker: 74696D40747175656C63682E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,tim@tquelch.com,,RULES_HIT:41:355:379:599:968:988:989:1260:1277:1313:1314:1345:1359:1381:1437:1516:1518:1534:1540:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:3138:3139:3140:3141:3142:3352:3865:3866:3867:3868:3870:3871:3872:3874:4470:5007:6261:7903:10004:10400:10848:11232:11658:11914:12043:12109:12114:12297:13069:13095:13311:13357:14721:21080:21212:21324:21433:21627:21660:21990:30054:30070,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: home37_26029dd27104 X-Filterd-Recvd-Size: 1464 Received: from localhost (180-150-39-252.b49627.bne.nbn.aussiebb.net [180.150.39.252]) (Authenticated sender: tim@tquelch.com) by omf02.hostedemail.com (Postfix) with ESMTPA; Sun, 13 Sep 2020 23:55:46 +0000 (UTC) From: Tim Quelch To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: Remove notmuch-mua-message-send-hook In-Reply-To: References: <20200912044540.852309-1-tim@tquelch.com> Date: Mon, 14 Sep 2020 09:56:33 +1000 Message-ID: <87h7s144em.fsf@quelch.name> MIME-Version: 1.0 Message-ID-Hash: OU4YFXXMRKUGJSSJD7ETKG4SOXIDUFOZ X-Message-ID-Hash: OU4YFXXMRKUGJSSJD7ETKG4SOXIDUFOZ X-MailFrom: tim@tquelch.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-TUID: exiT6WSgNhV+ > Looks good to me. everyone who rewrote notmuch-mua-message-send-hook > (i hope none) have to find better solution (or just...) I think that would be an incredibly small minority of people who did that. The obvious (and easiest) customisation point has been to add a function to `notmuch-message-send-hook` or to `message-send-hook` rather than actually relying on overwriting or advising `notmuch-mua-message-send-hook` > Hmm, this is defcustom. If that (old default) is stored in > custom-set-variables have to remove it -- at least my > custom-set-variables does not reference to this hook variable, so > most probably the effect (if any) is small... A safer route I guess would be to just change the default value of the hook and mark the function as obsolete. Tim Quelch