From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KNjRKMJFrF/1RQAA0tVLHw (envelope-from ) for ; Wed, 11 Nov 2020 20:12:50 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WC2cJMJFrF/0YAAAB5/wlQ (envelope-from ) for ; Wed, 11 Nov 2020 20:12:50 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D6C2494042B for ; Wed, 11 Nov 2020 20:12:49 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 80AAF28824; Wed, 11 Nov 2020 15:12:41 -0500 (EST) Received: from jb55.com (jb55.com [IPv6:2600:3c01::f03c:91ff:fe08:5bfb]) by mail.notmuchmail.org (Postfix) with ESMTPS id 58FA5203D7 for ; Wed, 11 Nov 2020 15:12:38 -0500 (EST) Received: from jb55.com (S010660e327dca171.vc.shawcable.net [24.84.152.187]) by jb55.com (OpenSMTPD) with ESMTPSA id debda363 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 11 Nov 2020 20:13:22 +0000 (UTC) From: William Casarin To: Jonas Bernoulli , notmuch@notmuchmail.org Subject: Re: [PATCH 01/27] emacs: silence byte-compiler In-Reply-To: <87v9echskt.fsf@bernoul.li> References: <20201108190311.1397-1-jonas@bernoul.li> <20201108190311.1397-2-jonas@bernoul.li> <874klznxom.fsf@jb55.com> <87v9echskt.fsf@bernoul.li> Date: Wed, 11 Nov 2020 12:12:34 -0800 Message-ID: <87h7pvvej1.fsf@jb55.com> MIME-Version: 1.0 Message-ID-Hash: L7U73LRMQJUNZPIKBD7GPQGPWWENMYB7 X-Message-ID-Hash: L7U73LRMQJUNZPIKBD7GPQGPWWENMYB7 X-MailFrom: jb55@jb55.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: -1.01 X-TUID: NmxCaGBZDdj+ Jonas Bernoulli writes: > William Casarin writes: >> LGTM, I have a similar patch here: id:20200908171536.20679-1-jb55@jb55.com > > So if I understood correctly the problem with that was that you were > unable to run the tests and therefore couldn't confirm that you fixed > the issue or even that there was an issue in the first place. More so I got a bug report from a user that I couldn't replicate. I haven't run the tests. > Well I was able to build and test and I can confirm that there is an > issue and that your commit fixes it. So it should be merged (though > I would merge my own variant because of the extra comment ;-). Sounds good, happy to use this patch instead. Cheers, Will