From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +NsBL4vY2WBWNwAAgWs5BA (envelope-from ) for ; Mon, 28 Jun 2021 16:11:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id aP3EKovY2WBEFAAAB5/wlQ (envelope-from ) for ; Mon, 28 Jun 2021 14:11:23 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9C0C7C284 for ; Mon, 28 Jun 2021 16:11:22 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 2BCC12908C; Mon, 28 Jun 2021 10:11:19 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 5563B29089 for ; Mon, 28 Jun 2021 10:11:17 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 0B9CD5FD21; Mon, 28 Jun 2021 10:11:17 -0400 (EDT) Received: (nullmailer pid 1845517 invoked by uid 1000); Mon, 28 Jun 2021 14:11:16 -0000 From: David Bremner To: Felipe Contreras Subject: Re: [PATCH 1/3] ruby: add new Database.open_with_config In-Reply-To: References: <20210604032901.3815539-1-felipe.contreras@gmail.com> <20210604032901.3815539-2-felipe.contreras@gmail.com> <875yxz18z4.fsf@tethera.net> Date: Mon, 28 Jun 2021 11:11:16 -0300 Message-ID: <87h7hiaxkr.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 45JX5ILGJKEYSEDX2J2MREGNF56BC7CE X-Message-ID-Hash: 45JX5ILGJKEYSEDX2J2MREGNF56BC7CE X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: "notmuch@notmuchmail.org" X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624889483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=bKeN9fDw/Bh46NJFOfzVZUlXJf7Pz4qfn0WiiqVegGA=; b=k+MvOT+3aBt7fFAykQFDcZW/bHpohE7cjkx1+ByCnT1I1W3Ae6GNQcZmaLptpen4N2s3AG G0+G9UlbKtbK/PVxjHU5kRHruTDeA4ScHbDHKsQdcWvh+7SeLAgxA/VncVWjYhA467HXhA fAQOqZED70eITaI/0PkpLUxxuc8wnrqNQwvrtoPIN0VSs2NSRRMCozvDtBf2GL/gwrK0Np UOfd0kLOgulrNyxTUuxzgEt51zMLXGZmYai1g/yciOUTsTOJ2EpTIVg6dSvq4xW1NaTN19 DNjc6hvCTn400ApqpGAP8a9y1w99v/KXkV+lUz5y9kd/JaYCyhG4UxyrM73ygw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624889483; a=rsa-sha256; cv=none; b=NoIwtpYllkihmShyKPBl58NujSEd/+IIi2HpdkHznvZic6ePSShreQdMEKNIbGf2pcARkr T7NPGqCvQj5bM/NWRg8hdxi52+Ff17LuAJQsxi4l6zFAns8DtxvJAjPbArbQKyBqSPRuOQ YP126fHlhWDh346+vLYAU6nl0jh92jraCR5rQFDdnNhtXPZ+dI7t7/ha2QTBYdsk6llKOo aHiDkgRmIH4puQQFdXcng/d7nDJs0zAgeI0rngqo2EFBkaqvkXF1KuPjS0ewQjM0mDwCLn wKWWMabz11xr59nqh07CapLx3B2roIs4nurUDBeH+4r+GdbMzgX2PCOFVYqs3Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.02 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 9C0C7C284 X-Spam-Score: -2.02 X-Migadu-Scanner: scn0.migadu.com X-TUID: wXPBOlJuO5Rd Felipe Contreras writes: > On Sun, Jun 27, 2021 at 1:02 PM David Bremner wrote: >> >> Felipe Contreras writes: >> >> > + ret = notmuch_database_open_with_config (database_path, mode, >> > + config_path, profile, &db, >> > + NULL); >> >> I'm curious why you ignore the error_message ouput parameter. Of course >> it's valid and supported for library users to do this, but this way >> there is no way for users of the ruby bindings to retrieve the >> additional information about the error. Particularly in the case of >> Xapian exceptions, this can be helpful for debugging. > > Because the patch is complex enough as it is. It shouldn't be that > difficult to add a new notmuch_rb_status_raise function that takes an > error message and produces a proper Ruby exception with that message, > but that should be done in a separate patch. > Agreed. d