From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AE7ZLdSb/mEqcQAAgWs5BA (envelope-from ) for ; Sat, 05 Feb 2022 16:46:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id wBueJtSb/mHlXwAAG6o9tA (envelope-from ) for ; Sat, 05 Feb 2022 16:46:28 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B9856371F0 for ; Sat, 5 Feb 2022 16:46:27 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id C23155F70F; Sat, 5 Feb 2022 15:46:24 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 9B2EF5F70C for ; Sat, 5 Feb 2022 15:46:21 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id BB0C35FBD2; Sat, 5 Feb 2022 10:46:20 -0500 (EST) Received: (nullmailer pid 4168290 invoked by uid 1000); Sat, 05 Feb 2022 15:46:19 -0000 From: David Bremner To: gmime-devel-list@gnome.org Subject: question about mbox and MIME Date: Sat, 05 Feb 2022 11:46:19 -0400 Message-ID: <87h79dnwok.fsf@tethera.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="==-=-=" Message-ID-Hash: PTJGKHZXRIKCCXJAJ2UOK5DSYCMATY5H X-Message-ID-Hash: PTJGKHZXRIKCCXJAJ2UOK5DSYCMATY5H X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: notmuch@notmuchmail.org X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644075988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: list-id:list-help:list-owner:list-unsubscribe:list-subscribe: list-post; bh=uUI2CDJdJ9SOYA7GH6JBsaO5iWprBQmwLHVM1LTlruA=; b=hpIsQqHF12wkFUSbKFjqeWFCxfvkBgR30Q5IdK3srHyqJj6tPSRqPSdJA+MT/rauhHYe2p s/f/ZtY1mCo9qfdoMJeV7LzEjGuvHuuu0CHNqb09QHHmA6/AUjpZHZpQjwOWMwHX+6nr9P iM1fS12igvnxyNGnpSvvh8yMOzep+y+IwCg2bnO6Znl1AgKBaLGSE/OSH7oEeN9jsZ10Sk uOcZYK/6+XUVFRYUYuTLwho3IdhuR2wt0llLb/47GSAlho02Uwklqn3qH9rGX3tHHVnw/B CACa0Cy44i+NakXVYfv78g7yp8FlKwLsP+NCVa+Wsyj7mJ92miXXY8WKaFNqvw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644075988; a=rsa-sha256; cv=none; b=ffzOXAwi3ou+IkblggtKSnSTetI+xs9KiurbjsmcKQt1Ssstiu7vLLlZoEYZVBRhtmi1xA zDNV5tA7v7wBk3ujIzNDPbNcSqpl3bURklK8P0GNahjECKjpfsz5RCORn0Qa/KhUVXyedw ojnVOqC9RJSHCfLOefMjLjAANLIgG8FuuD7xqJXa6pbONXjWT96IB4RBaIr2NSOHqYXndJ /syL7+QBodMaMCxvzZZlPmjMyPtW6433UIN+LRONIGhG0LBbGp7tEwfZ3M16NPnacSBZhW tvOMqyG18tEuqkqoIantudTbZ8zoJyPQpOdVqGqudK0EN6Vw2Q9r7u0XEqz4Zg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.83 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: B9856371F0 X-Spam-Score: -2.83 X-Migadu-Scanner: scn0.migadu.com X-TUID: dDj2Wv+u9Wxf --==-=-= Content-Type: text/plain Hi gmime experts; In notmuch we are using g_mime_parser_set_format (parser, GMIME_FORMAT_MBOX) to try to distinguish mboxes containing multiple messages from those containing only a single message [1]. The attached message breaks this, because it has an unescaped "From " inside a (text/plain) attachment. My question is if you consider this a gmime bug, or should mbox really take precedence over mime structure? I guess I can see both points of view, although it would be convenient for notmuch if gmime would consider wrapping in mime structure as a kind of escaping. cheers, David [1]: this is one of those regrettable backwards compatibility things. We tried to get rid of it about 7 years ago, and failed. --==-=-= Content-Type: message/rfc822 Content-Disposition: attachment; filename=mbox-attachment.eml From: David Bremner To: David Bremner Subject: Re: [RFC PATCH v2 12/12] emacs: whitespace cleanup for keybindings Date: Sat, 05 Feb 2022 10:19:09 -0400 Message-ID: <87k0e9o0pu.fsf@tethera.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Disposition: inline I figured out the race condition in the tests. The previous test was still running when the failing test started, the joys of using a shared emacs for running all of the tests in one file. The attached diff is split into the the commits that introduce the tests in question in my working series, but you should be able to just apply it on top of the posted series if you want. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-test-fixups.patch >From fc88cba7f1f37b9cf3b296eace2422dd0e173502 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Thu, 3 Feb 2022 21:05:05 -0400 Subject: [PATCH] test fixups --- test/T315-emacs-tagging.sh | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/test/T315-emacs-tagging.sh b/test/T315-emacs-tagging.sh index c9e3e53a..c26413ce 100755 --- a/test/T315-emacs-tagging.sh +++ b/test/T315-emacs-tagging.sh @@ -119,7 +119,8 @@ for mode in search show tree unthreaded; do (notmuch-$mode \"$os_x_darwin_thread\") (notmuch-test-wait) (execute-kbd-macro \"+tag-to-be-undone-$mode\") - (notmuch-tag-undo))" + (notmuch-tag-undo) + (notmuch-test-wait))" count=$(notmuch count "tag:tag-to-be-undone-$mode") test_expect_equal "$count" "0" @@ -128,9 +129,7 @@ for mode in search show tree unthreaded; do (notmuch-$mode \"$os_x_darwin_thread\") (notmuch-test-wait) (execute-kbd-macro \"+one-$mode\") - (notmuch-test-wait) (execute-kbd-macro \"+two-$mode\") - (notmuch-test-wait) (notmuch-tag-undo) (notmuch-test-wait) (execute-kbd-macro \"+three-$mode\"))" @@ -143,7 +142,6 @@ for mode in search show tree unthreaded; do (notmuch-$mode \"$os_x_darwin_thread\") (notmuch-test-wait) (execute-kbd-macro \"+one-$mode\") - (notmuch-test-wait) (execute-kbd-macro \"+two-$mode\") (notmuch-tag-undo) (notmuch-test-wait) @@ -159,7 +157,8 @@ for mode in search show tree unthreaded; do (notmuch-$mode \"$os_x_darwin_thread\") (notmuch-test-wait) (execute-kbd-macro \"+tag-to-be-undone-$mode\") - (execute-kbd-macro (kbd \"C-x u\")))" + (execute-kbd-macro (kbd \"C-x u\")) + (notmuch-test-wait))" count=$(notmuch count "tag:tag-to-be-undone-$mode") test_expect_equal "$count" "0" done -- 2.30.2 --=-=-=-- --==-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --==-=-=--