From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ALSIDgQZ52I6CAAAbAwnHQ (envelope-from ) for ; Mon, 01 Aug 2022 02:06:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KIOWDgQZ52IaTAEA9RJhRA (envelope-from ) for ; Mon, 01 Aug 2022 02:06:28 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E16B78F46 for ; Mon, 1 Aug 2022 02:06:27 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 700575E022; Mon, 1 Aug 2022 00:06:25 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id A51FE5E00E for ; Mon, 1 Aug 2022 00:06:22 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 78C8A5FBC0; Sun, 31 Jul 2022 20:06:21 -0400 (EDT) Received: (nullmailer pid 3159685 invoked by uid 1000); Mon, 01 Aug 2022 00:06:20 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] notmuch.c: add missing trailing newlines in two error messages In-Reply-To: <20220731173211.165098-1-tomi.ollila@iki.fi> References: <20220731173211.165098-1-tomi.ollila@iki.fi> Date: Sun, 31 Jul 2022 21:06:20 -0300 Message-ID: <87h72wq137.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 6NNUWGWYGDIA4AMJWYJBV6IRD6GDJSAA X-Message-ID-Hash: 6NNUWGWYGDIA4AMJWYJBV6IRD6GDJSAA X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: tomi.ollila@iki.fi X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659312388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=Vbf7E4o2jpzr9yDkLfyMitkQGFOGWb7SjBRSTYSUwvM=; b=fqpYp81/H6kl8NlKtS8Z5V5jr3mXgkeF9wIY1bpNXANAyqXblmYB1VFpg6QouhKAjo7wmd MXLiKw7Wq0V/eTAbIhUKFbcT0UIQ67BgkW3c8O4X8vVMiySF9tIMTB5Qh7MN+qsA0CLFUW qLRlfgKHmG2H1YPMG3dU+8b2hcRQ6+zC+9R+SJ+7RnoGPLSZUy1N2e3ABFEh8nXjC4yqAz TmTAsrPMUz6GLkjcaW/swFtpWaYNmd3BEngJvcP+bBhYnLUWPTmTSgz30/6a4oowepxDry FAGBzGsGzjpv6W1usvfh1rT3+6DKDQpniWagBjKVhirUOh/dMq+1ybR+vvu8IA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659312388; a=rsa-sha256; cv=none; b=dbu0Jlnq6ytud+t4lN67/yorb+v2ubVQVcuvliSJjS+9m5RZF8sCjp6PRJBFFARUooy+jo Je5bDhecxfnztu3SaGAdD4SM1DIo4r9+lDUvXKqYtfELv2K1a+uZp0yyzQ3vkK9iryI9cl els871hQDe7k0Hx7mhKmdoYFoygJpcS4COQSmIkz974EhOGYV4x+x1AalspfBNVetQ77vt AYIGYmbyn3eTSXIYyMjVs2q523hbi9mt57suYGeHPSKbNMPPyHdmW2aPj35Slk9d8B94lW 6wBKgJteK1co+YNPo68BxH7cPFnI+wsR7aSpf42G8ukxuy74piWdReqgJE1LZw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.38 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: E16B78F46 X-Spam-Score: -2.38 X-Migadu-Scanner: scn0.migadu.com X-TUID: opnsxJmgwz8z Tomi Ollila writes: > Removed duplicate error check (and the message) in 3rd case where > the same error message (w/o trailing newline) was present. > > In case of test/T040-setup.sh, command substitution deletes > trailing newlines, so related test there cannot be changed > (and therefore could not notice this user experience flaw). applied to master. d