From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: Re: [PATCH] notmuch.c: add missing trailing newlines in two error messages
Date: Sun, 31 Jul 2022 21:06:20 -0300 [thread overview]
Message-ID: <87h72wq137.fsf@tethera.net> (raw)
In-Reply-To: <20220731173211.165098-1-tomi.ollila@iki.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> Removed duplicate error check (and the message) in 3rd case where
> the same error message (w/o trailing newline) was present.
>
> In case of test/T040-setup.sh, command substitution deletes
> trailing newlines, so related test there cannot be changed
> (and therefore could not notice this user experience flaw).
applied to master.
d
prev parent reply other threads:[~2022-08-01 0:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-31 17:32 [PATCH] notmuch.c: add missing trailing newlines in two error messages Tomi Ollila
2022-07-31 18:57 ` David Bremner
2022-08-01 0:06 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h72wq137.fsf@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).