unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] test: increase cffi timeout
@ 2022-08-14 15:22 michaeljgruber+grubix+git
  2022-08-15 20:56 ` Tomi Ollila
  2022-08-16  7:37 ` David Bremner
  0 siblings, 2 replies; 3+ messages in thread
From: michaeljgruber+grubix+git @ 2022-08-14 15:22 UTC (permalink / raw)
  To: notmuch; +Cc: Michael J Gruber

From: Michael J Gruber <git@grubix.eu>

By default, the test suite uses 2min for other tests and 5s for cffi
tests. Sporadically, this leads to test failures caused by the timeout
on slower or loaded test infrastructure (as seen on ppc64le in Fedora's
infrastructure during branch time).

Increase the cffi timeout to the same 2m=120s.

Signed-off-by: Michael J Gruber <git@grubix.eu>
---
It's the first time I encountered this on Fedora's infrastructure during
a test build. In any case, having the timeouts similar may make sense in
general, unless we typically run into them in normal (local) use.

 bindings/python-cffi/tests/conftest.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bindings/python-cffi/tests/conftest.py b/bindings/python-cffi/tests/conftest.py
index 6835fd30..fe90c787 100644
--- a/bindings/python-cffi/tests/conftest.py
+++ b/bindings/python-cffi/tests/conftest.py
@@ -43,7 +43,7 @@ def notmuch(maildir):
         env = os.environ.copy()
         env['NOTMUCH_CONFIG'] = str(cfg_fname)
         proc = subprocess.run(cmd,
-                              timeout=5,
+                              timeout=120,
                               env=env)
         proc.check_returncode()
     return run
-- 
2.37.2.596.g72ccb331cf

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] test: increase cffi timeout
  2022-08-14 15:22 [PATCH] test: increase cffi timeout michaeljgruber+grubix+git
@ 2022-08-15 20:56 ` Tomi Ollila
  2022-08-16  7:37 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: Tomi Ollila @ 2022-08-15 20:56 UTC (permalink / raw)
  To: michaeljgruber+grubix+git, notmuch; +Cc: Michael J Gruber

On Sun, Aug 14 2022, michaeljgruber wrote:

> From: Michael J Gruber <git@grubix.eu>
>
> By default, the test suite uses 2min for other tests and 5s for cffi
> tests. Sporadically, this leads to test failures caused by the timeout
> on slower or loaded test infrastructure (as seen on ppc64le in Fedora's
> infrastructure during branch time).
>
> Increase the cffi timeout to the same 2m=120s.
>
> Signed-off-by: Michael J Gruber <git@grubix.eu>
> ---
> It's the first time I encountered this on Fedora's infrastructure during
> a test build. In any case, having the timeouts similar may make sense in
> general, unless we typically run into them in normal (local) use.
>
>  bindings/python-cffi/tests/conftest.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bindings/python-cffi/tests/conftest.py b/bindings/python-cffi/tests/conftest.py
> index 6835fd30..fe90c787 100644
> --- a/bindings/python-cffi/tests/conftest.py
> +++ b/bindings/python-cffi/tests/conftest.py
> @@ -43,7 +43,7 @@ def notmuch(maildir):
>          env = os.environ.copy()
>          env['NOTMUCH_CONFIG'] = str(cfg_fname)
>          proc = subprocess.run(cmd,
> -                              timeout=5,
> +                              timeout=120,

LGTM.

Tomi

>                                env=env)
>          proc.check_returncode()
>      return run
> -- 
> 2.37.2.596.g72ccb331cf

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] test: increase cffi timeout
  2022-08-14 15:22 [PATCH] test: increase cffi timeout michaeljgruber+grubix+git
  2022-08-15 20:56 ` Tomi Ollila
@ 2022-08-16  7:37 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2022-08-16  7:37 UTC (permalink / raw)
  To: michaeljgruber+grubix+git, notmuch; +Cc: Michael J Gruber

michaeljgruber+grubix+git@gmail.com writes:

> From: Michael J Gruber <git@grubix.eu>
>
> By default, the test suite uses 2min for other tests and 5s for cffi
> tests. Sporadically, this leads to test failures caused by the timeout
> on slower or loaded test infrastructure (as seen on ppc64le in Fedora's
> infrastructure during branch time).
>
> Increase the cffi timeout to the same 2m=120s.
>
> Signed-off-by: Michael J Gruber <git@grubix.eu>
> ---
> It's the first time I encountered this on Fedora's infrastructure during
> a test build. In any case, having the timeouts similar may make sense in
> general, unless we typically run into them in normal (local) use.
>

Applied to release and master.

It is still not exactly consistent with the other tests, since the
remaining tests have a 2 minute timeout per test script T*.sh, not per
subtest. The python CFFI tests have timeouts for both.

d

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-08-16  7:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-14 15:22 [PATCH] test: increase cffi timeout michaeljgruber+grubix+git
2022-08-15 20:56 ` Tomi Ollila
2022-08-16  7:37 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).