unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Carl Worth <cworth@cworth.org>
To: Jesse Rosenthal <jrosenthal@jhu.edu>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2] Name thread based on matching msgs instead of first msg.
Date: Wed, 21 Apr 2010 15:59:57 -0700	[thread overview]
Message-ID: <87fx2ojtsi.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <87eiieez9h.fsf@jhu.edu>

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

On Sat, 17 Apr 2010 13:59:22 -0400, Jesse Rosenthal <jrosenthal@jhu.edu> wrote:
> At the moment all threads are named based on the name of the first message
> in the thread. However, this can cause problems if people either start
> new threads by replying-all (as unfortunately, many out there do) or
> change the subject of their mails to reflect a shift in a thread on a
> list.

Thanks, Jesse. This is a nice new feature.

I've pushed this out now, followed up with several changes:

  * Simplify the assignment of the correct subject
  * Add test cases
  * Fix the feature to actually pass the tests

I know that my simplified version was broken (the tests showed
that). I'm not sure if the original version would have passed the tests
or not. But at least things seem to be working now.

-Carl

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2010-04-21 22:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-23  3:09 [PATCH] Name thread based on matching msgs instead of first msg Jesse Rosenthal
2010-03-23 17:31 ` James Vasile
2010-03-23 17:45   ` Sandra Snan
2010-03-23 19:07   ` Jesse Rosenthal
2010-04-17 17:59 ` [PATCH v2] " Jesse Rosenthal
2010-04-21 22:59   ` Carl Worth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fx2ojtsi.fsf@yoom.home.cworth.org \
    --to=cworth@cworth.org \
    --cc=jrosenthal@jhu.edu \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).