My repository is moving once again...

My repository is moving once again...

[Carl Worth]

[-- Attachment #1: Type: text/plain, Size: 2436 bytes --]

After a (much-too-long) hiatus, I just pushed a batch of changes to my
notmuch repository.

This includes the several changes that I recently reviewed on the
mailing list and said that I had committed locally and would push soon.

Additionally, I've pushed a few of bug fixes as follows:

  * Fix to never add a partially complete message to the database.

    Various interruptions to notmuch processing, (perhaps other bugs
    described below) would leave a half-complete message in the
    database. And later runs of notmuch would trip and fall over on this
    half-complete message. Thanks to a suggestion from Olly, notmuch now
    never adds the partial documents to the database so this problem
    should be avoided entirely.

  * Fix for really long message ID values.

    Scott mentioned various Xapian exceptions and notmuch internal
    errors that occurred after trying to add a message with a 300+
    character message ID. I've fixed this to now be handled well, (with
    new tests in the test suite to handle 512-character message IDs).

  * Make things easier after "make install" (for Linux at least)

    On Linux systems, the configure script will now identify the various
    paths supported by ldconfig (such as /usr/local/lib). Then, if the
    prefix is to one of these places (such as /usr/local/), make install
    will run ldconfig automatically. This will allow some people to be
    able to more easily run notmuch immediately after installing.

    Similarly, if the notmuch library is installed to some non-system
    directory, (such as --prefix=${HOME}/foo), then the final link of
    the shared binary will include a DT_RUNPATH entry to the directory
    in which the library is installed. This will also allow the notmuch
    binary to work immediately after "make install" without the user
    needing to set the LD_LIBRARY_PATH variable.

I implemented this last piece only on Linux. I think OS X doesn't need
additional support for this since linking binaries against libraries
might automatically encode the paths, (though I haven't tested). I also
haven't investigated what might be the right thing to do for Solaris,
(it's probably not all that different than what I did for Linux).

So if anybody wants to put together similar patches as needed for their
favorite platforms, then that would be great.

-Carl

-- 
carl.d.worth@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: My repository is moving once again...

[Michal Sojka]

On Sat, 05 Jun 2010, Carl Worth wrote:
>     new tests in the test suite to handle 512-character message IDs).

Hi Carl,

I see some changes in the test suite in your repo. Do you want me to
update the modularization patches I sent in
id:1273510084-19896-1-git-send-email-sojkam1@fel.cvut.cz?

Michal

Re: My repository is moving once again...

[Carl Worth]

[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]

On Mon, 07 Jun 2010 09:47:54 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> On Sat, 05 Jun 2010, Carl Worth wrote:
> >     new tests in the test suite to handle 512-character message IDs).
> 
> Hi Carl,
> 
> I see some changes in the test suite in your repo. Do you want me to
> update the modularization patches I sent in
> id:1273510084-19896-1-git-send-email-sojkam1@fel.cvut.cz?

Either you or me.

I am planning to review/merge your changes very soon. And I was aware
that this patch series was outstanding when I recently changed the test
suite.

So I made those test-suite changes with the assumption that I would take
any merge pain upon myself, rather than putting it on you.

If you'd like to help with the merge, that would be great, but you're
under no obligation.

I prmoise not to augment the test suite anymore before looking at that
patch series at least. So hopefully this is the very last time you'll
have to update it!

Thanks for your patience,

-Carl

-- 
carl.d.worth@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]