From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 8D40240D16A for ; Sat, 30 Oct 2010 13:38:35 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.89 X-Spam-Level: X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RRLhWfh3N25V; Sat, 30 Oct 2010 13:38:24 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 17DE840D166; Sat, 30 Oct 2010 13:38:24 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id B3CA8254007; Sat, 30 Oct 2010 13:38:23 -0700 (PDT) From: Carl Worth To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH 2/2] build: only link to what we really use In-Reply-To: <1288394207-10223-3-git-send-email-felipe.contreras@gmail.com> References: <1288394207-10223-1-git-send-email-felipe.contreras@gmail.com> <1288394207-10223-3-git-send-email-felipe.contreras@gmail.com> User-Agent: Notmuch/0.3.1 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Sat, 30 Oct 2010 13:38:23 -0700 Message-ID: <87fwvnpgao.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Oct 2010 20:38:35 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Sat, 30 Oct 2010 02:16:47 +0300, Felipe Contreras wrote: > At least linux has the -Wl,--as-needed option. >=20 > Signed-off-by: Felipe Contreras Thanks, Felipe. I've pushed this. I also followed it up with a change to do a configure-time check for the =2DWl,--as-needed option, (since I don't like having platform-specific conditionals in the Makefile). And this conditional: > -ifneq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1) > +ifeq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1) > +FINAL_NOTMUCH_LDFLAGS +=3D -Wl,--as-needed > +else wasn't only platform-specific, but actually using one conditional, ("linker resolved library dependencies"), for another, ("platform is linux"). That's a kind of fragility that I also don't like. But thanks very much for adding the --as-needed option. And please let me know if everything is building well for you now. (For the first patch you sent in this set, I had already pushed my own version.) =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFMzII/6JDdNq8qSWgRArxMAJ9KeMZTPztK86jwjsv+OZBIrDiRhwCfVRnm V4sgg1ijWq5q28I2I2J11Aw= =1TJi -----END PGP SIGNATURE----- --=-=-=--