From: Carl Worth <cworth@cworth.org>
To: Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] build: only link to what we really use
Date: Sat, 30 Oct 2010 13:38:23 -0700 [thread overview]
Message-ID: <87fwvnpgao.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <1288394207-10223-3-git-send-email-felipe.contreras@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]
On Sat, 30 Oct 2010 02:16:47 +0300, Felipe Contreras <felipe.contreras@gmail.com> wrote:
> At least linux has the -Wl,--as-needed option.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Thanks, Felipe.
I've pushed this.
I also followed it up with a change to do a configure-time check for the
-Wl,--as-needed option, (since I don't like having platform-specific
conditionals in the Makefile). And this conditional:
> -ifneq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1)
> +ifeq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1)
> +FINAL_NOTMUCH_LDFLAGS += -Wl,--as-needed
> +else
wasn't only platform-specific, but actually using one conditional, ("linker
resolved library dependencies"), for another, ("platform is
linux"). That's a kind of fragility that I also don't like.
But thanks very much for adding the --as-needed option.
And please let me know if everything is building well for you now. (For the
first patch you sent in this set, I had already pushed my own version.)
-Carl
--
carl.d.worth@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2010-10-30 20:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 23:16 [PATCH 0/2] build fixes Felipe Contreras
2010-10-29 23:16 ` [PATCH 1/2] build: fix DSO dependencies Felipe Contreras
2010-10-29 23:16 ` [PATCH 2/2] build: only link to what we really use Felipe Contreras
2010-10-30 20:38 ` Carl Worth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwvnpgao.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=felipe.contreras@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).