From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 8C24A429E5B for ; Mon, 27 Jun 2011 23:49:19 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 71Ja+ALjLNHI for ; Mon, 27 Jun 2011 23:49:19 -0700 (PDT) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id EAE16429E54 for ; Mon, 27 Jun 2011 23:49:18 -0700 (PDT) Received: by wwj40 with SMTP id 40so4326309wwj.2 for ; Mon, 27 Jun 2011 23:49:17 -0700 (PDT) Received: by 10.227.164.199 with SMTP id f7mr6320984wby.70.1309243757160; Mon, 27 Jun 2011 23:49:17 -0700 (PDT) Received: from localhost ([109.131.53.225]) by mx.google.com with ESMTPS id ex2sm4605328wbb.65.2011.06.27.23.49.13 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 27 Jun 2011 23:49:16 -0700 (PDT) From: Pieter Praet To: Robin Green , notmuch@notmuchmail.org Subject: Re: Race condition for '*' command In-Reply-To: <86aad5c6h2.fsf@dragonfly.greenrd.org> References: <86d3i1d06r.fsf@dragonfly.greenrd.org> <87sjqx31mp.fsf@servo.factory.finestructure.net> <86aad5c6h2.fsf@dragonfly.greenrd.org> User-Agent: Notmuch/0.5-243-g5a76944 (http://notmuchmail.org) Emacs/23.1.50.1 (x86_64-pc-linux-gnu) Date: Tue, 28 Jun 2011 08:49:06 +0200 Message-ID: <87fwmuxxgd.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2011 06:49:19 -0000 On Sun, 26 Jun 2011 10:00:41 +0100, Robin Green wrote: > On Sat, 25 Jun 2011 16:57:50 -0700, Jameson Graef Rollins wrote: > > On Sat, 25 Jun 2011 23:18:52 +0100, Robin Green wrote: > > > A race condition in the '*' command was noted when it was first > > > proposed. It looks to me like it still exists - has anything been done > > > about it? > > > > Hi, Robin. Can you explain what you mean by the "'*' command"? > > Sorry - forgot to say I'm talking about the notmuch emacs mode. In that > mode '*' applies tags to all messages matching the current search query, > which means that (here's the race condition) new results that have > appeared since the last refresh will also be tagged. This issue appears to stem from the fact that `notmuch-search-operate-all' runs (apply 'notmuch-tag notmuch-search-query-string action-split), in which `notmuch-search-query-string' points to a moving target. Could be solved by doing it with `notmuch-search', `mark-whole-buffer' and `notmuch-search-{add,remove}-tag-region' instead, but I'm sure there's a better way (of which I'm as of yet unaware). > -- > Robin > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch Peace -- Pieter