From: David Bremner <david@tethera.net>
To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] libnotmuch: build symbols list without relying on gcc -aux-info.
Date: Tue, 28 Jun 2011 16:45:48 -0300 [thread overview]
Message-ID: <87fwmtvixf.fsf@convex-new.cs.unb.ca> (raw)
In-Reply-To: <87iprpaibc.fsf@yoom.home.cworth.org>
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
On Tue, 28 Jun 2011 12:04:39 -0700, Carl Worth <cworth@cworth.org> wrote:
> I assume by "better" you mean that this one is less fragile to issues
> like the precise formatting of our notmuch.h header file.
Yes, that's what I meant.
> Meanwhile, though, our API *is* declared in the header file, (that's
> what the header file exists for), so I do prefer to base our symbol list
> on it.
Sure, that makes sense to me. I cherry-picked the sed patch to the
release branch.
> In fact, the ideal would probably be to take the objdump method and use
> it in the test suite to verify that its output matches the contents of
> notmuch.sym generated from the header file.
The second patch being turned into a test sounds like a great idea. I
can do that.
d
[-- Attachment #2: Type: application/pgp-signature, Size: 315 bytes --]
next prev parent reply other threads:[~2011-06-28 19:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 1:08 [PATCH] libnotmuch: build symbols list without relying on gcc -aux-info david
2011-06-27 2:42 ` david
2011-06-28 19:04 ` Carl Worth
2011-06-28 19:45 ` David Bremner [this message]
2011-11-29 6:51 ` New test for exported symbols David Bremner
2011-11-29 6:51 ` [PATCH 1/2] test/symbol-hiding: add some whitespace between tests David Bremner
2011-11-29 6:51 ` [PATCH 2/2] test/symbol-hiding: compare exported symbols with existing one David Bremner
2011-12-08 0:59 ` New test for exported symbols David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwmtvixf.fsf@convex-new.cs.unb.ca \
--to=david@tethera.net \
--cc=cworth@cworth.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).