From: Pieter Praet <pieter@praet.org>
To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] remove prefixes from `--output={threads, messages}' results
Date: Thu, 30 Jun 2011 19:54:10 +0200 [thread overview]
Message-ID: <87fwmrdx31.fsf@praet.org> (raw)
In-Reply-To: <871uyb479v.fsf@yoom.home.cworth.org>
On Thu, 30 Jun 2011 09:24:12 -0700, Carl Worth <cworth@cworth.org> wrote:
Non-text part: multipart/signed
> On Thu, 30 Jun 2011 10:19:49 +0200, Pieter Praet <pieter@praet.org> wrote:
> > Alter `do_search_threads()' and `do_search_messages()'
> > to not prepend each result with `thread:' respectively `id:'.
>
> My one concern here is that I've sometimes had a message-id without the
> id prefix and run a command like this:
>
> notmuch search 1309421989-22410-1-git-send-email-pieter@praet.org
>
> And I've gotten confused when I've received no output, (didn't I receive
> that mail? what happened?).
And unfortunately, that's not the only concern.
While this patch removes a mere 10 chars, it has (way too) far-reaching
consequences, not only for the test suite, but for the entire codebase.
Truth be told, this was never intended to be merged. I only sent this
patch to give a ~fair chance to what appears to be the general
consensus, but I much prefer the fix for do_search_tags() [1].
In fact, all the followup patches (the seemingly haphazard reply nesting
is intentional) are intended to be used with the do_search_tags() fix,
which I tentatively consider a much cleaner path.
> But I think this is a separate bug where the right fix is to make any
> search terms with no prefix search through *all* prefixed terms
> generated from email content. This would allow us to also avoid indexing
> some content twice, (currently we store subject, from, and to both with
> a prefix and without a prefix).
Indeed a most desirable (albeit perhaps long-term) goal.
Much as I'd like, I won't be able to make myself useful in that area for
the time being, as the only C I consider myself sufficiently capable of
pushing around is the one ending with "offee" :<
> -Carl
>
> --
> carl.d.worth@intel.com
Non-text part: application/pgp-signature
Peace
--
Pieter
[1] id:"1309422029-22924-1-git-send-email-pieter@praet.org"
next prev parent reply other threads:[~2011-06-30 17:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 2:09 Inconsistent output from "notmuch search --output=<foo>" Carl Worth
2010-11-24 3:30 ` Jameson Rollins
2010-11-24 8:38 ` Sebastian Spaeth
2010-11-24 10:36 ` David Edmondson
2010-11-24 19:40 ` Carl Worth
2010-11-25 15:41 ` Jameson Rollins
2010-11-24 9:25 ` Michal Sojka
2011-03-29 0:39 ` Sebastian Spaeth
2011-06-30 8:19 ` [PATCH] remove prefixes from `--output={threads,messages}' results Pieter Praet
2011-06-30 16:24 ` [PATCH] remove prefixes from `--output={threads, messages}' results Carl Worth
2011-06-30 17:54 ` Pieter Praet [this message]
2011-06-30 8:20 ` [PATCH] add `tag:' prefix to `--output=tags' results Pieter Praet
2011-06-30 8:35 ` [PATCH] fix breakage in `notmuch-hello-generate-tag-alist' due to `tag:' prefix Pieter Praet
2011-06-30 8:36 ` [PATCH] fix breakage in `notmuch-select-tag-with-completion' " Pieter Praet
2011-11-12 15:17 ` [PATCH] add `tag:' prefix to `--output=tags' results David Bremner
2011-11-13 14:14 ` Jani Nikula
2011-11-16 11:07 ` Pieter Praet
2011-11-13 23:00 ` Jameson Graef Rollins
2011-11-14 6:56 ` Dmitry Kurochkin
2011-11-16 11:28 ` Pieter Praet
2012-01-16 10:56 ` David Edmondson
2012-01-16 10:58 ` Pieter Praet
2011-06-30 8:20 ` [PATCH] emacs: add keybind and function to stash Message-ID without prefix Pieter Praet
2011-06-30 8:23 ` [PATCH] test: stashing in notmuch-{show,search} Pieter Praet
2011-11-13 1:12 ` David Bremner
2011-11-16 11:38 ` [PATCH] test: emacs: tidy up "Stashing in notmuch-show" test Pieter Praet
2011-11-18 19:26 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwmrdx31.fsf@praet.org \
--to=pieter@praet.org \
--cc=cworth@cworth.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).