From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 34F67431FD0 for ; Fri, 9 Sep 2011 10:24:13 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id us9WhBqI+Iyb for ; Fri, 9 Sep 2011 10:24:12 -0700 (PDT) Received: from smtprelay03.ispgateway.de (smtprelay03.ispgateway.de [80.67.31.26]) by olra.theworths.org (Postfix) with ESMTP id 9477D431FB6 for ; Fri, 9 Sep 2011 10:24:12 -0700 (PDT) Received: from [87.180.32.105] (helo=stokes.schwinge.homeip.net) by smtprelay03.ispgateway.de with esmtpa (Exim 4.68) (envelope-from ) id 1R24nP-0002rW-Cy for notmuch@notmuchmail.org; Fri, 09 Sep 2011 19:23:19 +0200 Received: (qmail 10549 invoked from network); 9 Sep 2011 17:22:51 -0000 Received: from kepler.schwinge.homeip.net (192.168.111.7) by stokes.schwinge.homeip.net with QMQP; 9 Sep 2011 17:22:51 -0000 Received: (nullmailer pid 17211 invoked by uid 1000); Fri, 09 Sep 2011 17:22:51 -0000 From: Thomas Schwinge To: Austin Clements Subject: Re: [PATCH] notmuch restore --accumulate In-Reply-To: References: <1315249637-20179-1-git-send-email-thomas@schwinge.name> <87liu2kcq6.fsf@servo.factory.finestructure.net> <20110909090633.GA3178@localdomain> <87fwk63v86.fsf@kepler.schwinge.homeip.net> User-Agent: Notmuch/0.7-57-g64222ef (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Fri, 09 Sep 2011 19:22:49 +0200 Message-ID: <87fwk53a1i.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Df-Sender: dGhvbWFzQHNjaHdpbmdlLm5hbWU= Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Sep 2011 17:24:13 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! On Fri, 9 Sep 2011 12:13:06 -0400, Austin Clements wrote: > The idea behind sending the test first is that people can see that it fai= ls > and that the subsequent patch indeed fixes it. What I find works well is= to > submit the test case with the test marked as broken and then the main pat= ch, > including the change to un-mark it as broken. Ah, that's indeed a good approach for bug fixes (and it also preserves git bisect compatibility), but still: why separate patches for new functionality? (I'm not trying to be a pain here, but would like to understand your rationale behind this.) Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAEBAgAGBQJOaktpAAoJEGe3hdm9kOiirqMIAJiZJ8pRMX/5TiE3GRTmeJva nIlKKRN7SSOsTehjxqtekS79baAyt1wl7/5HBZYSvB5Rq110yG/QGsZmIOsE2bcD 57L/G84r9u9vcevfF+WQlTiqA2afOGCfXgaa66spD1WGgek1S9l4zmsKreXKp14E IlMPSCRtOcq+ZOC0y01QFTxs/fFcb/u2Cga7cefbDEQV89znQ2rzt8+p1AaZWeME amkrI8SuIyr6jyFVzUoc9vC69b+g1jFM7QECkN9lLBETNTBBQiaZg2h5FQL21WBW Ijaz+RSW9zUWJP2eduRJ5lMhXSIGxnq/vXAIzB9ois5F6JR/EMh8gGH3lDVlSik= =05QI -----END PGP SIGNATURE----- --=-=-=--