From: Sebastian Spaeth <Sebastian@SSpaeth.de>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues
Date: Wed, 28 Sep 2011 18:36:32 +0200 [thread overview]
Message-ID: <87fwjgoc8f.fsf@SSpaeth.de> (raw)
In-Reply-To: <1307822683-848-1-git-send-email-amdragon@mit.edu>
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
On Sat, 11 Jun 2011 16:04:26 -0400, Austin Clements <amdragon@MIT.EDU> wrote:
> Here's the reworked patch series that uses atomic sections more
> heavily rather than changing the removal API. This is atomic-new-v6
> on http://awakening.csail.mit.edu/git/notmuch.git .
I just caught up implementing find_message_by_filename and
begin|end_atomic
One oddity, since databases are opened in read-only by default, I was
surprise to see find_message_by_filename on such a database have my
python instance crash...
> lib: Add an API to find a message by filename.
> Culled from "lib: Add API's to find by filename and ..." in the old
> series. What I kept is identical.
db.find_message_by_filename("moo")
Internal error: Failure to ensure database is writable
(lib/directory.cc:100).
Outch?
Sebastian
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2011-09-28 16:36 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 7:58 [PATCH 00/10] Fix 'notmuch new' atomicity issues Austin Clements
2011-02-18 7:58 ` [PATCH 01/10] test: Test atomicity of notmuch new Austin Clements
2011-05-04 20:32 ` [PATCH 01/10 v2] " Austin Clements
2011-02-18 7:58 ` [PATCH 02/10] new: Don't loose messages on SIGINT Austin Clements
2011-02-18 7:58 ` [PATCH 03/10] new: Defer updating directory mtimes until the end Austin Clements
2011-02-18 7:58 ` [PATCH 04/10] lib: Make _notmuch_message_sync capable of deleting a message Austin Clements
2011-02-18 7:58 ` [PATCH 05/10] lib: Indicate if there are more filenames after removal Austin Clements
2011-02-18 7:58 ` [PATCH 06/10] lib: Add API's to find by filename and remove a filename from a message Austin Clements
2011-02-18 7:58 ` [PATCH 07/10] new: Use the new filename removal API Austin Clements
2011-02-18 7:58 ` [PATCH 08/10] new: Synchronize maildir flags eagerly Austin Clements
2011-02-18 7:58 ` [PATCH 09/10] lib: Add notmuch_database_{begin,end}_atomic Austin Clements
2011-02-18 7:59 ` [PATCH 10/10] new: Wrap adding a message in an atomic section Austin Clements
2011-04-26 4:13 ` [PATCH 00/10] Fix 'notmuch new' atomicity issues Austin Clements
2011-05-04 20:30 ` Austin Clements
2011-05-29 2:51 ` Austin Clements
2011-06-08 22:05 ` Carl Worth
2011-06-10 21:11 ` Austin Clements
2011-06-10 22:02 ` Carl Worth
2011-06-10 22:27 ` Austin Clements
2011-06-11 20:04 ` [PATCH v6 00/17] " Austin Clements
2011-06-11 20:04 ` [PATCH 02/17] test: Report test failures from test_expect_* Austin Clements
2011-06-11 20:04 ` [PATCH 03/17] lib: Add missing status check in _notmuch_message_remove_filename Austin Clements
2011-06-11 20:04 ` [PATCH 04/17] test: Test atomicity of notmuch new Austin Clements
2011-06-11 20:04 ` [PATCH 05/17] new: Don't lose messages on SIGINT Austin Clements
2011-06-11 20:04 ` [PATCH 06/17] new: Defer updating directory mtimes until the end Austin Clements
2011-06-11 20:04 ` [PATCH 07/17] lib: Add notmuch_database_{begin,end}_atomic Austin Clements
2011-06-11 20:04 ` [PATCH 08/17] lib: Add support for nested atomic sections Austin Clements
2011-06-11 20:04 ` [PATCH 09/17] lib: Indicate if there are more filenames after removal Austin Clements
2011-06-11 20:04 ` [PATCH 10/17] lib: Remove message document directly after removing the last file name Austin Clements
2011-06-11 20:04 ` [PATCH 11/17] lib: Add an API to find a message by filename Austin Clements
2011-06-11 20:04 ` [PATCH 12/17] lib: Wrap notmuch_database_add_message in an atomic section Austin Clements
2011-06-11 20:04 ` [PATCH 13/17] new: Cleanup. Put removed/renamed message count in add_files_state_t Austin Clements
2011-06-11 20:04 ` [PATCH 14/17] new: Cleanup. De-duplicate file name removal code Austin Clements
2011-06-11 20:04 ` [PATCH 15/17] new: Synchronize maildir flags eagerly Austin Clements
2011-06-11 20:04 ` [PATCH 16/17] new: Wrap adding and removing messages in atomic sections Austin Clements
2011-06-11 20:04 ` [PATCH 17/17] lib: Improve notmuch_database_{add, remove}_message documentation Austin Clements
2011-06-11 20:49 ` [PATCH 01/17] test: Fix message when skipping test_expect_equal* tests Austin Clements
2011-06-11 20:53 ` [PATCH v6 00/17] Fix 'notmuch new' atomicity issues Austin Clements
2011-06-22 19:39 ` Austin Clements
2011-06-29 6:37 ` Austin Clements
2011-07-08 18:09 ` Austin Clements
2011-09-13 12:39 ` David Bremner
2011-09-24 3:14 ` David Bremner
2011-09-24 4:03 ` Austin Clements
2011-09-25 2:36 ` David Bremner
2011-09-26 22:07 ` Austin Clements
2011-09-26 23:32 ` NEWS for 0.9 David Bremner
2011-09-27 13:08 ` Ali Polatel
2011-09-28 16:36 ` Sebastian Spaeth [this message]
2011-09-29 15:01 ` [PATCH v6 00/17] Fix 'notmuch new' atomicity issues Austin Clements
2011-09-30 9:21 ` Sebastian Spaeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwjgoc8f.fsf@SSpaeth.de \
--to=sebastian@sspaeth.de \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).