unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Austin Clements <amdragon@MIT.EDU>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/3] test: check that Emacs UI does not call notmuch for non-inlinable parts
Date: Sun, 27 Nov 2011 21:46:15 -0500	[thread overview]
Message-ID: <87fwh92cco.fsf@awakening.csail.mit.edu> (raw)
In-Reply-To: <1322271878-32614-2-git-send-email-dmitry.kurochkin@gmail.com>

LGTM (modulo any changes that propagate from the first patch)

On Sat, 26 Nov 2011 05:44:37 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> The patch adds two new test cases:
> 
> * Do not call notmuch for non-inlinable application/mpeg parts
> * Do not call notmuch for non-inlinable audio/mpeg parts
> 
> The application/mpeg test passes thanks to a workaround for
> application/* Content-Types.  The audio/mpeg is currently broken.

  reply	other threads:[~2011-11-28  2:44 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-26  1:44 [PATCH 1/3] test: add functions to count how much times notmuch was called Dmitry Kurochkin
2011-11-26  1:44 ` [PATCH 2/3] test: check that Emacs UI does not call notmuch for non-inlinable parts Dmitry Kurochkin
2011-11-28  2:46   ` Austin Clements [this message]
2011-11-26  1:44 ` [PATCH 3/3] emacs: do not call notmuch show " Dmitry Kurochkin
2011-11-28  2:54   ` Austin Clements
2011-11-28  2:44 ` [PATCH 1/3] test: add functions to count how much times notmuch was called Austin Clements
2011-11-28  3:09   ` Dmitry Kurochkin
2011-11-28  3:28 ` [PATCH 0/3] emacs: do not call notmuch show for non-inlinable parts Dmitry Kurochkin
2011-11-28  3:28   ` [PATCH 1/3] test: add functions to count how much times notmuch was called Dmitry Kurochkin
2011-11-28 20:42     ` Tomi Ollila
2011-11-28 21:26       ` Dmitry Kurochkin
2011-11-29 12:58         ` Tomi Ollila
2011-11-29 21:03           ` Dmitry Kurochkin
2011-11-30 11:53             ` Tomi Ollila
2011-11-29 14:40         ` Jameson Graef Rollins
2011-11-28  3:28   ` [PATCH 2/3] test: check that Emacs UI does not call notmuch for non-inlinable parts Dmitry Kurochkin
2011-11-28  3:28   ` [PATCH 3/3] emacs: do not call notmuch show " Dmitry Kurochkin
2011-11-28  3:39   ` [PATCH 0/3] " Austin Clements
2011-11-28 14:24     ` Jameson Graef Rollins
2011-11-28 21:13 ` [PATCH v3 " Dmitry Kurochkin
2011-11-28 21:13   ` [PATCH v3 1/3] test: add functions to count how much times notmuch was called Dmitry Kurochkin
2011-11-28 21:13   ` [PATCH v3 2/3] test: check that Emacs UI does not call notmuch for non-inlinable parts Dmitry Kurochkin
2011-11-28 21:13   ` [PATCH v3 3/3] emacs: do not call notmuch show " Dmitry Kurochkin
2011-11-29 21:19 ` [PATCH v4 0/3] " Dmitry Kurochkin
2011-11-29 21:19   ` [PATCH v4 1/3] test: add functions to count how much times notmuch was called Dmitry Kurochkin
2011-11-30 11:57     ` Tomi Ollila
2011-11-29 21:19   ` [PATCH v4 2/3] test: check that Emacs UI does not call notmuch for non-inlinable parts Dmitry Kurochkin
2011-11-29 21:19   ` [PATCH v4 3/3] emacs: do not call notmuch show " Dmitry Kurochkin
2011-12-07 15:11   ` [PATCH v4 0/3] " Dmitry Kurochkin
2011-12-08  1:00   ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fwh92cco.fsf@awakening.csail.mit.edu \
    --to=amdragon@mit.edu \
    --cc=dmitry.kurochkin@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).