From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.
Date: Mon, 26 Dec 2011 15:09:55 +0400 [thread overview]
Message-ID: <87fwg71tdo.fsf@gmail.com> (raw)
In-Reply-To: <cunpqfbtxu2.fsf@hotblack-desiato.hh.sledj.net>
Hi David.
On Mon, 26 Dec 2011 10:46:13 +0000, David Edmondson <dme@dme.org> wrote:
> On Fri, 23 Dec 2011 23:01:33 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > * Revert changes to notmuch-show-advance-and-archive.
>
> Why? (I mean, because the change is poor or just that it's unrelated or
> because I didn't mention it)
>
Because it is unrelated.
And can you please explain why `when' is better than `if' here? Then I
will know which one to use the next time :)
> > * Can we split this in two patches? One for rewind and another for
> > advance.
>
> I'll think about that. Is there a specific reason? I'm not particularly
> in favour of splitting things just for the sake of it.
>
Because they are independent and can be split. And it is easier to
review (and work in general, I suppose) with two smaller patches than
with a single bigger one.
Though, since you got two other reviews already, you can just ignore
this.
> > * Does this patch change the behavior of the functions or is it just
> > meant to simplify the code? If it is the former, it would be really
> > nice to have tests for it.
>
> I believe that it changes the behaviour. I'll write tests.
Thanks.
Regards,
Dmitry
next prev parent reply other threads:[~2011-12-26 11:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <id:"1324553312-10972-1-git-send-email-dme@dme.org">
2011-12-23 18:41 ` [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode David Edmondson
2011-12-23 19:01 ` Dmitry Kurochkin
2011-12-26 10:46 ` David Edmondson
2011-12-26 11:09 ` Dmitry Kurochkin [this message]
2011-12-26 22:00 ` David Edmondson
2011-12-26 22:24 ` Jameson Graef Rollins
2011-12-27 7:56 ` David Edmondson
2011-12-25 1:06 ` Austin Clements
2011-12-26 4:11 ` Aaron Ecay
2011-12-26 10:54 ` David Edmondson
2011-12-26 10:49 ` David Edmondson
2011-12-28 15:22 ` David Edmondson
2011-12-28 18:04 ` Aaron Ecay
2011-12-28 20:21 ` Jameson Graef Rollins
2011-12-29 8:42 ` David Edmondson
2011-12-29 12:08 ` [PATCH 1/2] " David Edmondson
2011-12-29 12:08 ` [PATCH 2/2] test: Add tests for advance/rewind David Edmondson
2011-12-29 16:05 ` David Edmondson
2012-01-06 17:10 ` Jameson Graef Rollins
2012-01-06 17:31 ` David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwg71tdo.fsf@gmail.com \
--to=dmitry.kurochkin@gmail.com \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).