From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 02DEE429E25 for ; Tue, 10 Jan 2012 18:56:46 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JWTRSwoeSg4x for ; Tue, 10 Jan 2012 18:56:45 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 64F52431FD0 for ; Tue, 10 Jan 2012 18:56:45 -0800 (PST) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id D533A66E014B; Tue, 10 Jan 2012 18:56:42 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from finestructure.net (gwave-171.ligo.caltech.edu [131.215.114.171]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id F2A8766E0115; Tue, 10 Jan 2012 18:56:29 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id DC91C3E7; Tue, 10 Jan 2012 18:56:29 -0800 (PST) From: Jameson Graef Rollins To: Aaron Ecay , Notmuch Mail Subject: Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging In-Reply-To: References: <1325975294-646-1-git-send-email-jrollins@finestructure.net> <1325975294-646-2-git-send-email-jrollins@finestructure.net> <1325975294-646-3-git-send-email-jrollins@finestructure.net> <87boqdr3mz.fsf@servo.finestructure.net> User-Agent: Notmuch/0.10.2+168~g34b8bac (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Tue, 10 Jan 2012 18:56:29 -0800 Message-ID: <87fwfnne02.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2012 02:56:46 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, 09 Jan 2012 00:02:20 -0500, Aaron Ecay wrote: > On Sun, 08 Jan 2012 18:49:56 -0800, Jameson Graef Rollins wrote: > > On Sun, 08 Jan 2012 20:08:59 -0500, Aaron Ecay wr= ote: > > > > > > - It would be good to make show-next &optional. This will enable code > > > to call the fn with only two arguments, and not showing next will be > > > the default behavior. > >=20 > > That's a nice idea. Probably better for a separate patch, though. >=20 > This patch introduces show-next as a new argument to the function. So it > can and should make it &optional, if that is the appropriate semantics > for it to have. Actually, the show-next argument was already part of the function. I did not introduce it. And it wasn't optional originally, so if we want to change that behavior we should probably do so in a separate patch. > That said, here=E2=80=99s an alternate proposal: provide two functions as= the > =E2=80=9Cexternal=E2=80=9D API, namely =E2=80=98notmuch-show-{add,remove}= -tag-thread=E2=80=99 (by > parallelism with =E2=80=98notmuch-show-{add,remove}-tag=E2=80=99). These= could be > thin wrappers around =E2=80=98notmuch-show-tag-thread-internal=E2=80=99, = which would > then not be intended to be called by user code. I think that's a better idea. In the next version I'll add something like this instead. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJPDPpdAAoJEO00zqvie6q8L60QAJtv4I4MvMwLqceiWECdcgys icJ4AUK5VKkL0B4qRZtmMenGvBWmGAGcSnlcvaZWLveO56lnSRU66D9naXNheShn KPdBdgH2Atq2RofhwyRTik0JO/tlzJ6N9+N0uUjqLcf8mqt3Q2hc+3KpyBT5SuLp 0MmD7zOIoJEKf5q32OWNbw3qIUOVNH0VMbCdm38g01xqPMJPnHGy4xICwMZW273d tn2/hGUg2J/ZE9jJ5KWXntm2m4xlBYq/GfJ3VsQpg9gN1PmgeMH7HzEj63PAkLbm A4SVL3tPlKGfKEvWorsTqZJVIqF+tgMNE5YnGz9fyxDr4/AyXl+fjQ2w/hEnXTTQ 98Ldr8Wn0Lq/pEphIKTtAhCorzHC93d6wqo2jd2BK0t18vqhK7o5Q6lr83DHySDR RZyTN9buRFzfL3lO5M2tB+344a0coYztuOZLWyfJhxcwMbnGonK5mC1OQiqQtLdk BlY7gdQvB1HXSjYRMssKWWlJyFo/yr313LRe45nbIRoT3fVO4xWXa/0utwKSeHvr 2Irp6OnNd4z37A1DnK9w4uhmd3INktCwmOLDLygsgqOqFDBgesy7IVAgpfAv1rv7 Pl9WrO6dGsGu/qvlFaOP4+KnM/F6DGMJwh+AqpDw7XKNYi0x/yR3CGffcS4YkK8I 0zPtiudex6vs5lU+X2ow =LlNY -----END PGP SIGNATURE----- --=-=-=--