From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 92715429E26 for ; Thu, 12 Jan 2012 09:09:55 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uUDElE5mJulG for ; Thu, 12 Jan 2012 09:09:55 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id C0E70431FB6 for ; Thu, 12 Jan 2012 09:09:54 -0800 (PST) Received: by wgbds11 with SMTP id ds11so1947514wgb.2 for ; Thu, 12 Jan 2012 09:09:53 -0800 (PST) Received: by 10.181.13.208 with SMTP id fa16mr7786908wid.12.1326388193621; Thu, 12 Jan 2012 09:09:53 -0800 (PST) Received: from localhost ([109.131.126.209]) by mx.google.com with ESMTPS id di5sm10055363wib.3.2012.01.12.09.09.52 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 12 Jan 2012 09:09:52 -0800 (PST) From: Pieter Praet To: Dmitry Kurochkin , David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH v2] Output unmodified Content-Type header value for JSON format. In-Reply-To: <87obw6prpd.fsf@gmail.com> References: <1321659905-24367-1-git-send-email-dmitry.kurochkin@gmail.com> <1321676321-27745-1-git-send-email-dmitry.kurochkin@gmail.com> <87sjlktgi6.fsf@zancas.localnet> <87obw6prpd.fsf@gmail.com> User-Agent: Notmuch/0.10.2+115~gadd29f6 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Thu, 12 Jan 2012 18:08:08 +0100 Message-ID: <87fwfkluh3.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2012 17:09:55 -0000 On Sun, 20 Nov 2011 22:35:42 +0400, Dmitry Kurochkin wrote: > On Sat, 19 Nov 2011 08:59:29 -0400, David Bremner wrote: > > On Sat, 19 Nov 2011 08:18:41 +0400, Dmitry Kurochkin wrote: > > > Before the change, notmuch used g_mime_content_type_to_string(3) > > > function to output Content-Type header value. Turns out it outputs > > > only "type/subtype" part and ignores all parameters. Also, if there > > > is no Content-Type header, default "text/plain" value is used. > > > > Hi Dmitry; > > > > I haven't analyzed the substance of your patch yet, but I did have a > > couple thoughts while reading your mail. > > > > - It seems that every time we change the json format, we have a round of > > suffering because people are unable to detect a mismatch between their > > emacs code and the cli. Not that this is your problem necessarily, but > > it would be nice if someone (TM), would come up with some version info > > for the json output, and a patch to check it on the emacs side. > > > > IMO this is a good idea. > > > - The previous point is a bit of a counterargument to this, but in > > general, I think I prefer patches that modify the core seperate from > > those that do emacs (or python, or ...) stuff. > > > > I couls separate it. I made is a single patch to avoid having a > revision with broken emacs UI (and tests). > I'd like to propose to always apply patch series on a *topic* branch which would then be merged back into 'master', thus avoiding this issue altogether whilst making it more obvious which patches belong together (eg. for easier cross-referencing with the ML). > Regards, > Dmitry > > > - I understand you want to make your patches reviewable without applying > > by including lots of context, but at a certain point it has actually > > the opposite effect for me. I just don't read 900+ line emails ;). Of > > course, I can still apply the patch and look at it, so it's really up > > to you. > > > > d > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch Peace -- Pieter