From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 3E54E431FB6 for ; Wed, 7 Mar 2012 11:52:16 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4wQEOOILEgTV for ; Wed, 7 Mar 2012 11:52:15 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 7A7FD431FAE for ; Wed, 7 Mar 2012 11:52:15 -0800 (PST) Received: by wgbds10 with SMTP id ds10so3355575wgb.2 for ; Wed, 07 Mar 2012 11:52:14 -0800 (PST) Received: by 10.180.24.4 with SMTP id q4mr28694884wif.7.1331149934119; Wed, 07 Mar 2012 11:52:14 -0800 (PST) Received: from localhost ([109.131.36.23]) by mx.google.com with ESMTPS id h19sm38115817wiw.9.2012.03.07.11.52.13 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 07 Mar 2012 11:52:13 -0800 (PST) From: Pieter Praet To: David Bremner , notmuch Subject: Re: plans for 0.12 In-Reply-To: <8762eo2b89.fsf@zancas.localnet> References: <87mx87j8eh.fsf@zancas.localnet> <877gz4dnl2.fsf@praet.org> <8762eo2b89.fsf@zancas.localnet> User-Agent: Notmuch/0.11.1+210~g6afc43e (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Wed, 07 Mar 2012 20:52:05 +0100 Message-ID: <87fwdk42ai.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Gm-Message-State: ALoCoQlLDboJMebkPpABL7VC6cXGXbzFlOPPiRVnpAsXKLfvOJdYHjU1ArmJywH4ctY3SWJ3WY6L X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2012 19:52:16 -0000 On Thu, 01 Mar 2012 18:43:50 -0400, David Bremner wrote: > On Thu, 01 Mar 2012 22:21:29 +0100, Pieter Praet wrote: > > > > Some of the features added/refactored post-0.11.1 don't have any > > test coverage yet. Should they, before wrapping up 0.12 ? > > (not a rhetorical question, I'm genuinely asking for opinions) > > > > Hi Pieter; > > My initial answer is probably not. I see the tests as mainly useful > during development, for detecting regressions. I think most people doing > development will be working from git, rather than the distribution > tarballs we ship. > > On the other hand, adding tests is also not that risky, so if the > concensus is strongly in favour of integrating them pre 0.12, and > somebody wants to review them all, then I'm willing to consider it. > Fair enough. Just in case anyone considers them beneficial and/or is willing to review (whether it be for inclusion in 0.12 or later), I've gotten rid of the merge conflict by moving the last test to a new file called `emacs-search' [1] (also see [2]). Other than that, it remains unchanged. > d Peace -- Pieter [1] id:"1331149792-17192-1-git-send-email-pieter@praet.org" [2] id:"87aa47euao.fsf@praet.org"