From: Jameson Graef Rollins <jrollins@finestructure.net>
To: David Bremner <david@tethera.net>,
Austin Clements <amdragon@MIT.EDU>,
notmuch@notmuchmail.org
Cc: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Subject: Re: Parsing regression with gmime-2.6?
Date: Thu, 08 Mar 2012 10:27:21 -0800 [thread overview]
Message-ID: <87fwdj6j92.fsf@servo.finestructure.net> (raw)
In-Reply-To: <87wr6xmlml.fsf@zancas.localnet>
[-- Attachment #1: Type: text/plain, Size: 1558 bytes --]
On Tue, 06 Mar 2012 18:04:50 -0400, David Bremner <david@tethera.net> wrote:
> There seems to be something weird going on with gmime-2.6; maybe we
> didn't catch some api change?
>
> I noticed a surprising number of messages failing to parse, so I wrote a
> script to take a random sample of 1000 messages and run notmuch show on
> them. A shocking 650 to 700 of them fail to parse with gmime-2.6. No
> failures are reported with gmime-2.4.
This *is* shockingly high, and very confusing. Somehow all of the tests
pass? That's very strange, particularly since there are enough real
messages used in the tests that we should experience at least one of
these failures, right? Is there really nothing special about the
messages that are failing to parse? Your later patches seem to indicate
that this has something to do with mbox, although you don't mention that
hear.
I thought I had been using gmime-2.6 for the last month, so I was very
skeptical of this issue. Unfortunately I just found a bug in the
configure script [0] that meant I had actually been using gmime-2.4.
However, since fixing things and actually using gmime-2.6 now, I still
don't see any problems.
If the problem is specific to mbox, which we explicitly don't support, I
don't think this is tragic enough to warrant removing gmime-2.6 as a
dependency satisfier for 0.12 in Debian. In an event, a more explicit
description of the problem you're seeing would be helpful.
jamie.
[0] id:"1331225101-24385-1-git-send-email-jrollins@finestructure.net"
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2012-03-08 18:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 21:39 Internal error on line 296 of mime-node.c David Bremner
2012-03-01 21:57 ` Austin Clements
2012-03-02 2:35 ` David Bremner
2012-03-02 2:35 ` [PATCH 1/2] test: utility function to add a pre-generated message to the database David Bremner
2012-03-02 2:35 ` [PATCH 2/2] test: add new test file for mime parsing David Bremner
2012-03-06 18:26 ` [PATCH] Handle errors in mime_node_open Austin Clements
2012-03-06 22:04 ` Parsing regression with gmime-2.6? David Bremner
2012-03-08 15:35 ` [WIP PATCH] debugging gmime-2.6 fail David Bremner
2012-03-08 18:08 ` David Bremner
2012-03-08 18:27 ` Jameson Graef Rollins [this message]
2012-03-08 20:30 ` Parsing regression with gmime-2.6? Daniel Kahn Gillmor
2012-03-08 21:32 ` Jameson Graef Rollins
2012-03-08 21:40 ` Daniel Kahn Gillmor
2012-03-08 21:59 ` Jameson Graef Rollins
2012-03-08 21:48 ` [PATCH] mime_node_open: check if the file is in mbox format, and inform gmime David Bremner
2012-03-08 22:05 ` Jameson Graef Rollins
2012-03-09 10:50 ` Tomi Ollila
2012-03-09 13:31 ` [PATCH] mime_node_open: skip envelope from lines at the start of messages David Bremner
2012-03-09 13:56 ` David Bremner
2012-03-09 16:20 ` Daniel Kahn Gillmor
2012-03-10 13:25 ` David Bremner
2012-03-10 14:45 ` Tomi Ollila
2012-03-11 1:51 ` [PATCH] Handle errors in mime_node_open David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwdj6j92.fsf@servo.finestructure.net \
--to=jrollins@finestructure.net \
--cc=amdragon@MIT.EDU \
--cc=david@tethera.net \
--cc=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).