From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 473AE431FB6 for ; Sun, 27 May 2012 15:30:32 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.8 X-Spam-Level: X-Spam-Status: No, score=-0.8 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g4wPnpKR0JMU for ; Sun, 27 May 2012 15:30:30 -0700 (PDT) Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id B3880431FAF for ; Sun, 27 May 2012 15:30:30 -0700 (PDT) Received: by wgbds1 with SMTP id ds1so1135059wgb.2 for ; Sun, 27 May 2012 15:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=schoepe.org; s=google; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=jbUSsCSfLtVoSdGZ9ufnIGz+c1a6ln+YYgaMEhQPzRw=; b=kJKL1gXkqTcKbpdc/zBZ00avY1uGhwZ20EtqRUVR8BUbVXQYu+ygTV1vRJfDbm7t12 RRKlA+sN3s/+8Nhs2TZtY6UG3MPBcTt8VqJShB3Q/VtfcqxvTuCyfw/Sy/0+SUk1WOl9 9VAcyc3c4bcEIZWixN5um1MXIrxM13JfrI1mw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type:x-gm-message-state; bh=jbUSsCSfLtVoSdGZ9ufnIGz+c1a6ln+YYgaMEhQPzRw=; b=XPlSNeCQBrIYoRbij6dffbkDOXiwTKr/pykPWOkVqSP8H7DFEPgAhZ02mnmwE6hxaU 90nfJqCxgU5eGTrjm/wZNUFhMrqMu8C52oFinTg4P3m78oZdm4MwIm8Yy6eq21JCEUBO jIRzlctvDatL1d9Ok6TiV6jdXrG3DTjcdjOojbqJqke/LA6JiYxyDXwTMGl2EOnsa7z5 kiVbO+iY7HnixgIPq3gXTHCMefAeeBsPmGgw1YVoekSgqlJItZr8LQL/j5H+ala47TPw PcHdlQ+c7QYVfNrvyrs+SBWPAQmDpbpL7TjsX7DFucWbVUc1CrCMQlFvYpZ9MZe0hWsO 5xNg== Received: by 10.216.228.88 with SMTP id e66mr3151043weq.208.1338157829360; Sun, 27 May 2012 15:30:29 -0700 (PDT) Received: from localhost (dslb-088-069-134-222.pools.arcor-ip.net. [88.69.134.222]) by mx.google.com with ESMTPS id d10sm26197863wiy.3.2012.05.27.15.30.26 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 27 May 2012 15:30:27 -0700 (PDT) From: Daniel Schoepe To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH v4 0/4] Allow JSON to use non-entire thread, and use for elide In-Reply-To: <1335258675-29439-1-git-send-email-markwalters1009@gmail.com> References: <1335258675-29439-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.12+114~gf15c55e (http://notmuchmail.org) Emacs/24.0.95.1 (x86_64-pc-linux-gnu) Date: Mon, 28 May 2012 00:30:20 +0200 Message-ID: <87fwal2r5v.fsf@schoepe.localhost> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Gm-Message-State: ALoCoQkF0wBTWkTpFyzNO16IJFTGd6lbyQThlnTS44TnDGajo6+hbRAY7jOU5sGB15yoR0O6SA5T X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 May 2012 22:30:32 -0000 --=-=-= Content-Type: text/plain On Tue, 24.04.2012 11:11, Mark Walters wrote: > The first three patches implement the client side changes: one to > allow null messages to be output in Json (without upsetting the > parsing/structure), one to do the command line parsing for > --entire-thread=false and one to update the schemata. > > The final emacs patch is independent (and the first three make sense > without it) and uses this new functionality to implement the elide > option. > > I think this addresses all review comments LGTM (all four patches). I think both version of the command line parsing patch would be acceptable, but the second one seems cleaner to me. Cheers, Daniel --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJPwqr8AAoJEIaTAtce+Z+JlHoQALXvhxdjXshXRnjd5f0Aj4Q3 Ulv9F1TBivRpZdsDEKTmREcxwUSvuBxR4gIMb/Tdams+nFLWZIYDwN1pv+Bn0h/Z tN+xHnn5oDWDPQjRIgxpzVZzpWKaF8pgO8kdWooJSaNIleue7ZcnDwsQYOEkS+0E 3YE8S6seLqncHLvpn911rszJmkcwGt5SPY2/lTijUUn7d7RCggHK5hpKDNzICTuB JCbiqH/agGIweUx9iAa4UjOC5CePpgdHSQ5rP5E51XUtI32glH+sAo5nzx4iuLjZ 9QyZ5RS9ENh4espxUYjRUBBIybZtox9Bo69z2s+4FUj9Ihjs0RNtHrAr1UMPdAkb wZ0+PjSRONl93lk9KUcssoDo9VatEzr4BxPo0vROXqnAkaKLZ8C5KwHZE6jXZh+l wLDgO3RM3TjUvRK5ubiLTWIHR4hjbJRUJg/iWuJl1bYquwzM0KT7Hvr2L1bLNdui 0WooqWCPVe50HKZYNEpw1/fvbJTfTutXBSA7QLKMG87IIveuFt91zpQnpVPylGCZ clMqyHi0qSZOsbZkaJViPaaQF2nIrUt4SKaj4/akWtI74hqC/za6fq7KUFZLleu3 QtXnt7Tt50XFxopf6ghbl95AfaaiP4ulaV/8BAmsLvak+yKvtqLQMbea79o0dBSH p50QUzxCiBy6jkQO8CXR =93zT -----END PGP SIGNATURE----- --=-=-=--