unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] test: show tests
Date: Fri, 31 Aug 2012 18:00:53 -0300	[thread overview]
Message-ID: <87fw72dbei.fsf@zancas.localnet> (raw)
In-Reply-To: <1332171061-27983-3-git-send-email-markwalters1009@gmail.com>

Mark Walters <markwalters1009@gmail.com> writes:

> ---
>  test/notmuch-test |    1 +
>  test/show         |   47 +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 48 insertions(+), 0 deletions(-)
>  create mode 100755 test/show

Hi Mark;

This series was tagged stale at some point, but I imagine the conflict
was trivial (since it mainly adds a new file). If you do decide to
rebase it, how about some actual commit messages? Also, I wonder if you
should use the new test_expect_equal_json function?

d

      reply	other threads:[~2012-08-31 21:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19 15:30 [PATCH 0/2] test: tests for notmuch-show.c Mark Walters
2012-03-19 15:31 ` [PATCH 1/2] test: show expected output files Mark Walters
2012-03-19 15:31 ` [PATCH 2/2] test: show tests Mark Walters
2012-08-31 21:00   ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fw72dbei.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).