From: David Bremner <david@tethera.net>
To: Ben Gamari <bgamari.foss@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 4/4] database: Handle error while deleting uncompacted database
Date: Sat, 02 Nov 2013 09:23:29 -0300 [thread overview]
Message-ID: <87fvrfrnzy.fsf@zancas.localnet> (raw)
In-Reply-To: <1382998997-9938-4-git-send-email-bgamari.foss@gmail.com>
Ben Gamari <bgamari.foss@gmail.com> writes:
> We never checked to ensure that the rmtree() of the old database
> succeeded.
>
Is there some reason these patches (and the existing compact code in the
lib) is using fprintf and not the status callback function? Most places
we don't (yet) have logging callbacks, but here we do.
d
next prev parent reply other threads:[~2013-11-02 12:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 22:23 [PATCH 1/4] test: Add compact test Ben Gamari
2013-10-28 22:23 ` [PATCH 2/4] compact: Give user more feedback on failure renaming Ben Gamari
2013-10-28 22:23 ` [PATCH 3/4] compact: Provide user with more error feedback Ben Gamari
2013-10-28 22:23 ` [PATCH 4/4] database: Handle error while deleting uncompacted database Ben Gamari
2013-11-02 12:23 ` David Bremner [this message]
2013-11-04 20:06 ` Ben Gamari
2013-10-29 11:03 ` [PATCH 1/4] test: Add compact test Tomi Ollila
2013-10-31 4:10 ` Ben Gamari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvrfrnzy.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=bgamari.foss@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).