From: Mark Walters <markwalters1009@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 02/11] test: New tests for Emacs charset handling
Date: Fri, 25 Apr 2014 07:18:35 +0100 [thread overview]
Message-ID: <87fvl2szib.fsf@qmul.ac.uk> (raw)
In-Reply-To: <20140424182931.GP25817@mit.edu>
On Thu, 24 Apr 2014, Austin Clements <amdragon@MIT.EDU> wrote:
> Quoth Mark Walters on Apr 24 at 3:38 pm:
>>
>> On Mon, 21 Apr 2014, Austin Clements <amdragon@MIT.EDU> wrote:
>> > The test of viewing 8bit messages is known-broken. The rest pass, but
>> > for very fragile reasons. The next several commits will fix the
>> > known-broken test and make our charset handling robust.
>>
>> Hi
>>
>> On one of my systems one of these (non-broken) tests fails. I am not
>> sure whether I messed up my emacs/environment when doing stuff remotely
>> recently so it could just be my system
>>
>>
>> > ---
>> > test/T455-emacs-charsets.sh | 141 ++++++++++++++++++++++++++++++++++++++++++++
>> > test/test-lib.el | 4 +-
>> > 2 files changed, 144 insertions(+), 1 deletion(-)
>> > create mode 100755 test/T455-emacs-charsets.sh
>> >
>> > diff --git a/test/T455-emacs-charsets.sh b/test/T455-emacs-charsets.sh
>> > new file mode 100755
>> > index 0000000..a42a1d2
>> > --- /dev/null
>> > +++ b/test/T455-emacs-charsets.sh
>> > @@ -0,0 +1,141 @@
>> > +#!/usr/bin/env bash
>> > +
>> > +test_description="emacs notmuch-show charset handling"
>> > +. ./test-lib.sh
>> > +
>> > +
>> > +UTF8_YEN=$'\xef\xbf\xa5'
>> > +BIG5_YEN=$'\xa2\x44'
>> > +
>> > +# Add four messages with unusual encoding requirements:
>> > +#
>> > +# 1) text/plain in quoted-printable big5
>> > +generate_message \
>> > + [id]=test-plain@example.com \
>> > + '[content-type]="text/plain; charset=big5"' \
>> > + '[content-transfer-encoding]=quoted-printable' \
>> > + '[body]="Yen: =A2=44"'
>> > +
>> > +# 2) text/plain in 8bit big5
>> > +generate_message \
>> > + [id]=test-plain-8bit@example.com \
>> > + '[content-type]="text/plain; charset=big5"' \
>> > + '[content-transfer-encoding]=8bit' \
>> > + '[body]="Yen: '$BIG5_YEN'"'
>> > +
>> > +# 3) text/html in quoted-printable big5
>> > +generate_message \
>> > + [id]=test-html@example.com \
>> > + '[content-type]="text/html; charset=big5"' \
>> > + '[content-transfer-encoding]=quoted-printable' \
>> > + '[body]="<html><body>Yen: =A2=44</body></html>"'
>> > +
>> > +# 4) application/octet-stream in quoted-printable of big5 text
>> > +generate_message \
>> > + [id]=test-binary@example.com \
>> > + '[content-type]="application/octet-stream"' \
>> > + '[content-transfer-encoding]=quoted-printable' \
>> > + '[body]="Yen: =A2=44"'
>> > +
>> > +notmuch new > /dev/null
>> > +
>> > +# Test rendering
>> > +
>> > +test_begin_subtest "Text parts are decoded when rendering"
>> > +test_emacs '(notmuch-show "id:test-plain@example.com")
>> > + (test-visible-output "OUTPUT.raw")'
>> > +awk 'show {print} /^$/ {show=1}' < OUTPUT.raw > OUTPUT
>> > +cat <<EOF >EXPECTED
>> > +Yen: $UTF8_YEN
>> > +EOF
>> > +test_expect_equal_file OUTPUT EXPECTED
>> > +
>> > +test_begin_subtest "8bit text parts are decoded when rendering"
>> > +test_emacs '(notmuch-show "id:test-plain-8bit@example.com")
>> > + (test-visible-output "OUTPUT.raw")'
>> > +awk 'show {print} /^$/ {show=1}' < OUTPUT.raw > OUTPUT
>> > +cat <<EOF >EXPECTED
>> > +Yen: $UTF8_YEN
>> > +EOF
>> > +test_expect_equal_file OUTPUT EXPECTED
>> > +
>> > +test_begin_subtest "HTML parts are decoded when rendering"
>> > +test_emacs '(notmuch-show "id:test-html@example.com")
>> > + (test-visible-output "OUTPUT.raw")'
>> > +awk 'show {print} /^$/ {show=1}' < OUTPUT.raw > OUTPUT
>> > +cat <<EOF >EXPECTED
>> > +[ text/html ]
>> > +Yen: $UTF8_YEN
>> > +EOF
>> > +test_expect_equal_file OUTPUT EXPECTED
>>
>> It's this test: I get an extra newline after the UFT8_YEN.
>>
>> This is with emacs 23.4.1 on a Debian wheezy(ish) system.
>>
>> But as said it could be my fault: I think some odd things happened when
>> I tried to install emacs 24 and 23 simultaneously to help testing
>> things.
>
> I can reproduce this. Tests that involve HTML rendering are always
> finicky like this since there are so many different HTML renderers.
> Maybe I could normalize the spacing? sed '/^$/d;s/ */ /g' or so?
That sounds plausible. What output would you get if the test genuinely
fails? I guess the key thing is to try and make sure the test doesn't
pass in that case.
Best wishes
Mark
next prev parent reply other threads:[~2014-04-25 6:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 18:37 [PATCH 00/11] Improve charset and cid: handling Austin Clements
2014-04-21 18:37 ` [PATCH 01/11] emacs: Remove redundant NTH argument from `notmuch-get-bodypart-content' Austin Clements
2014-07-10 9:46 ` David Bremner
2014-04-21 18:37 ` [PATCH 02/11] test: New tests for Emacs charset handling Austin Clements
2014-04-24 14:38 ` Mark Walters
2014-04-24 18:29 ` Austin Clements
2014-04-25 6:18 ` Mark Walters [this message]
2014-04-25 13:57 ` Tomi Ollila
2014-04-21 18:37 ` [PATCH 03/11] emacs: Fix coding system in `notmuch-show-view-raw-message' Austin Clements
2014-07-10 9:48 ` David Bremner
2014-09-23 17:59 ` David Bremner
2014-04-21 18:37 ` [PATCH 04/11] emacs: Track full message and part descriptor in w3m CID store Austin Clements
2014-07-10 9:52 ` David Bremner
2015-01-24 16:45 ` Austin Clements
2014-04-21 18:37 ` [PATCH 05/11] emacs: Create an API for fetching parts as undecoded binary Austin Clements
2014-04-21 18:37 ` [PATCH 06/11] emacs: Remove broken `notmuch-get-bodypart-content' API Austin Clements
2014-07-11 11:48 ` David Bremner
2015-01-24 17:10 ` Austin Clements
2014-04-21 18:37 ` [PATCH 07/11] emacs: Return unibyte strings for binary part data Austin Clements
2014-04-21 18:37 ` [PATCH 08/11] emacs: Support caching in notmuch-get-bodypart-{binary, text} Austin Clements
2014-04-24 10:46 ` Mark Walters
2014-04-24 18:12 ` Austin Clements
2014-04-25 6:42 ` Mark Walters
2015-01-24 18:06 ` Austin Clements
2014-04-21 18:37 ` [PATCH 09/11] emacs: Use generalized content caching in w3m CID code Austin Clements
2014-04-21 18:37 ` [PATCH 10/11] emacs: Rewrite content ID handling Austin Clements
2014-04-21 18:37 ` [PATCH 11/11] emacs: Support cid: references with shr renderer Austin Clements
2014-05-01 9:20 ` David Edmondson
2015-01-24 17:12 ` Austin Clements
2014-04-21 20:26 ` [PATCH 00/11] Improve charset and cid: handling Tomi Ollila
2014-04-26 10:50 ` Mark Walters
2015-01-24 17:29 ` Austin Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvl2szib.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).