[PATCH v1] emacs: Forwarded messages should not have modified buffers

[PATCH v1] emacs: Forwarded messages should not have modified buffers

[David Edmondson]

[-- Attachment #1: Type: text/plain, Size: 848 bytes --]

When the user begins forwarding a message, the resulting composition
buffer should not be marked as modified, in order that it can
immediately be killed without prompting.
---
 emacs/notmuch-mua.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index 95e4a4d..2c58886 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -346,7 +346,8 @@ the From: address first."
     (message-forward-make-body cur)
     ;; `message-forward-make-body' shows the User-agent header.  Hide
     ;; it again.
-    (message-hide-headers)))
+    (message-hide-headers)
+    (set-buffer-modified-p nil)))
 
 (defun notmuch-mua-new-reply (query-string &optional prompt-for-sender reply-all)
   "Compose a reply to the message identified by QUERY-STRING.
-- 
2.0.0.rc2


[-- Attachment #2: Type: application/pgp-signature, Size: 310 bytes --]

Re: [PATCH v1] emacs: Forwarded messages should not have modified buffers

[Tomi Ollila]

On Mon, Jun 02 2014, David Edmondson <dme@dme.org> wrote:

> When the user begins forwarding a message, the resulting composition
> buffer should not be marked as modified, in order that it can
> immediately be killed without prompting.
> ---

LGTM.

Tomi


>  emacs/notmuch-mua.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index 95e4a4d..2c58886 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -346,7 +346,8 @@ the From: address first."
>      (message-forward-make-body cur)
>      ;; `message-forward-make-body' shows the User-agent header.  Hide
>      ;; it again.
> -    (message-hide-headers)))
> +    (message-hide-headers)
> +    (set-buffer-modified-p nil)))
>  
>  (defun notmuch-mua-new-reply (query-string &optional prompt-for-sender reply-all)
>    "Compose a reply to the message identified by QUERY-STRING.
> -- 
> 2.0.0.rc2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v1] emacs: Forwarded messages should not have modified buffers

[Mark Walters]

Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Mon, Jun 02 2014, David Edmondson <dme@dme.org> wrote:
>
>> When the user begins forwarding a message, the resulting composition
>> buffer should not be marked as modified, in order that it can
>> immediately be killed without prompting.
>> ---
>
> LGTM.
>
> Tomi

and me.  +1

Mark

>
>
>>  emacs/notmuch-mua.el | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
>> index 95e4a4d..2c58886 100644
>> --- a/emacs/notmuch-mua.el
>> +++ b/emacs/notmuch-mua.el
>> @@ -346,7 +346,8 @@ the From: address first."
>>      (message-forward-make-body cur)
>>      ;; `message-forward-make-body' shows the User-agent header.  Hide
>>      ;; it again.
>> -    (message-hide-headers)))
>> +    (message-hide-headers)
>> +    (set-buffer-modified-p nil)))
>>  
>>  (defun notmuch-mua-new-reply (query-string &optional prompt-for-sender reply-all)
>>    "Compose a reply to the message identified by QUERY-STRING.
>> -- 
>> 2.0.0.rc2
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> http://notmuchmail.org/mailman/listinfo/notmuch
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v1] emacs: Forwarded messages should not have modified buffers

[David Bremner]

David Edmondson <dme@dme.org> writes:

> When the user begins forwarding a message, the resulting composition
> buffer should not be marked as modified, in order that it can
> immediately be killed without prompting.

It seems the quoted-printable encoding of that message (at least
delivered to me) prevents applying that patch. Would you mind redoing
it, possibly without signing it?

cheers,

d

[PATCH v1] emacs: Forwarded messages should not have modified buffers

[David Edmondson]

When the user begins forwarding a message, the resulting composition
buffer should not be marked as modified, in order that it can
immediately be killed without prompting.
---
emacs/notmuch-mua.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index 95e4a4d..2c58886 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -346,7 +346,8 @@ the From: address first."
    (message-forward-make-body cur)
    ;; `message-forward-make-body' shows the User-agent header.  Hide
    ;; it again.
-    (message-hide-headers)))
+    (message-hide-headers)
+    (set-buffer-modified-p nil)))

(defun notmuch-mua-new-reply (query-string &optional prompt-for-sender reply-all)
  "Compose a reply to the message identified by QUERY-STRING.
-- 
2.0.0.rc2

Re: [PATCH v1] emacs: Forwarded messages should not have modified buffers

[David Bremner]

David Edmondson <dme@dme.org> writes:
> @@ -346,7 +346,8 @@ the From: address first."
>     (message-forward-make-body cur)
>     ;; `message-forward-make-body' shows the User-agent header.  Hide
>     ;; it again.
> -    (message-hide-headers)))
> +    (message-hide-headers)
> +    (set-buffer-modified-p nil)))
>
> (defun notmuch-mua-new-reply (query-string &optional prompt-for-sender reply-all)
>   "Compose a reply to the message identified by QUERY-STRING.
> -- 
> 2.0.0.rc2

Bah. Sometimes mail systems suck. I finally managed to apply this after
some effort. For future reference, it was still quoted printable and
(even more mysteriously) something mangled the indentation of the
context lines, moving them one space left; once can see this most
clearly on the last two lines.

d

Re: [PATCH v1] emacs: Forwarded messages should not have modified buffers

[Tomi Ollila]

On Sun, Jun 22 2014, David Bremner <david@tethera.net> wrote:

> David Edmondson <dme@dme.org> writes:
>> @@ -346,7 +346,8 @@ the From: address first."
>>     (message-forward-make-body cur)
>>     ;; `message-forward-make-body' shows the User-agent header.  Hide
>>     ;; it again.
>> -    (message-hide-headers)))
>> +    (message-hide-headers)
>> +    (set-buffer-modified-p nil)))
>>
>> (defun notmuch-mua-new-reply (query-string &optional prompt-for-sender reply-all)
>>   "Compose a reply to the message identified by QUERY-STRING.
>> -- 
>> 2.0.0.rc2
>
> Bah. Sometimes mail systems suck. I finally managed to apply this after
> some effort. For future reference, it was still quoted printable and
> (even more mysteriously) something mangled the indentation of the
> context lines, moving them one space left; once can see this most
> clearly on the last two lines.

I don't see that as quoted-unreadable; from 'V' output:

From: David Edmondson <dme@dme.org>
In-Reply-To: <87wqch5309.fsf@zancas.localnet>
Date: Mon, 16 Jun 2014 06:30:11 +0100
Message-Id: <1E19E1E0-044E-4616-B951-FC8FEFA49071@dme.org>
To: David Bremner <david@tethera.net>
X-Mailer: Apple Mail (2.1878.2)
Cc: notmuch@notmuchmail.org
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

(and no =... strings...)

> d

Tomi

Re: [PATCH v1] emacs: Forwarded messages should not have modified buffers

[David Edmondson]

On 22 Jun 2014, at 11:44, David Bremner <david@tethera.net> wrote:
> Bah. Sometimes mail systems suck. I finally managed to apply this after
> some effort. For future reference, it was still quoted printable and
> (even more mysteriously) something mangled the indentation of the
> context lines, moving them one space left; once can see this most
> clearly on the last two lines.

Sorry. Buried with $dayjob.

Re: [PATCH v1] emacs: Forwarded messages should not have modified buffers

[David Bremner]

David Edmondson <dme@dme.org> writes:

> On 22 Jun 2014, at 11:44, David Bremner <david@tethera.net> wrote:
>> Bah. Sometimes mail systems suck. I finally managed to apply this after
>> some effort. For future reference, it was still quoted printable and
>> (even more mysteriously) something mangled the indentation of the
>> context lines, moving them one space left; once can see this most
>> clearly on the last two lines.
>
> Sorry. Buried with $dayjob.

Not to worry. Tomi points out above that he got an uncorrupted version,
so it might even be something on my end.

d