From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D7D21431FBC for ; Wed, 18 Jun 2014 14:11:38 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c3n6P7RIOsLb for ; Wed, 18 Jun 2014 14:11:34 -0700 (PDT) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id D5FD6431FAE for ; Wed, 18 Jun 2014 14:11:33 -0700 (PDT) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1WxN8g-0004c6-NA; Wed, 18 Jun 2014 18:11:26 -0300 Received: (nullmailer pid 5527 invoked by uid 1000); Wed, 18 Jun 2014 21:11:23 -0000 From: David Bremner To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH 5/5] lib: Separate all phrases indexed by _notmuch_message_gen_terms In-Reply-To: <1402886434-16169-6-git-send-email-amdragon@mit.edu> References: <1402886434-16169-1-git-send-email-amdragon@mit.edu> <1402886434-16169-6-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.18+13~g1adde01 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Wed, 18 Jun 2014 18:11:23 -0300 Message-ID: <87fvj1gbyc.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jun 2014 21:11:39 -0000 Austin Clements writes: > This adds a 100 termpos gap between all phrases indexed by > _notmuch_message_gen_terms. This fixes a bug where terms from the end > of one header and the beginning of another header could match together > in a single phrase and a separate bug where term positions of > un-prefixed terms overlapped. > > This fix only affects newly indexed messages. Messages that are > already indexed won't benefit from this fix without re-indexing, but > the fix won't make things any worse for existing messages. The series looks OK to me. It took me a little while to understand the problem with multiple parts was that the term positions currently start from zero for each part. If you happen to be re-rolling the series for some other reason, maybe you could be more explicit about that. I wouldn't bother just for that though. d