From: David Bremner <david@tethera.net>
To: Austin Clements <aclements@csail.mit.edu>, notmuch@notmuchmail.org
Subject: Re: [PATCH 06/11] lib: Internal support for querying and creating ghost messages
Date: Sun, 05 Oct 2014 10:30:30 +0200 [thread overview]
Message-ID: <87fvf2q5p5.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <1412345958-8278-7-git-send-email-aclements@csail.mit.edu>
Austin Clements <aclements@csail.mit.edu> writes:
> + message->flags &= ~(1 << NOTMUCH_MESSAGE_FLAG_GHOST);
What do you think about using bit set / clear / read macros? I don't
insist, but I wonder if it would make this part more readable.
> + else if (*i == "Tghost")
> + message->flags |= (1 << NOTMUCH_MESSAGE_FLAG_GHOST);
> + else
It makes me faintly unhappy to have the prefix hardcoded here.
Not sure if there is a sensible solution.
next prev parent reply other threads:[~2014-10-05 8:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 14:19 [PATCH 00/11] Add ghost messages and fix thread linking Austin Clements
2014-10-03 14:19 ` [PATCH 01/11] lib: Move message ID compression to _notmuch_message_create_for_message_id Austin Clements
2014-10-03 14:19 ` [PATCH 02/11] lib: Refactor _notmuch_database_link_message Austin Clements
2014-10-05 7:45 ` David Bremner
2014-10-05 23:20 ` Austin Clements
2014-10-06 6:04 ` David Bremner
2014-10-06 13:25 ` Austin Clements
2014-10-03 14:19 ` [PATCH 03/11] lib: Handle empty date value Austin Clements
2014-10-03 14:19 ` [PATCH 04/11] lib: Add a ghost messages database feature Austin Clements
2014-10-03 14:19 ` [PATCH 05/11] lib: Update database schema doc for ghost messages Austin Clements
2014-10-03 14:19 ` [PATCH 06/11] lib: Internal support for querying and creating " Austin Clements
2014-10-05 8:30 ` David Bremner [this message]
2014-10-05 23:24 ` Austin Clements
2014-10-06 6:19 ` David Bremner
2014-10-06 16:03 ` Austin Clements
2014-10-03 14:19 ` [PATCH 07/11] lib: Implement ghost-based thread linking Austin Clements
2014-10-03 14:19 ` [PATCH 08/11] lib: Implement upgrade to ghost messages feature Austin Clements
2014-10-05 8:56 ` David Bremner
2014-10-05 23:29 ` Austin Clements
2014-10-06 6:03 ` David Bremner
2014-10-03 14:19 ` [PATCH 09/11] lib: Enable " Austin Clements
2014-10-03 14:19 ` [PATCH 10/11] test: Test upgrade to " Austin Clements
2014-10-03 14:19 ` [PATCH 11/11] lib: Remove unnecessary thread linking steps when using ghost messages Austin Clements
2014-10-04 8:30 ` [PATCH 00/11] Add ghost messages and fix thread linking Tomi Ollila
2014-10-04 20:15 ` Austin Clements
2014-10-05 9:07 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvf2q5p5.fsf@maritornes.cs.unb.ca \
--to=david@tethera.net \
--cc=aclements@csail.mit.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).