From: David Bremner <david@tethera.net>
To: Istvan Marko <notmuch@kismala.com>, Jani Nikula <jani@nikula.org>,
notmuch@notmuchmail.org
Subject: Re: [PATCH v2] Use the Xapian::DB_RETRY_LOCK flag when available
Date: Thu, 05 May 2016 07:33:25 -0300 [thread overview]
Message-ID: <87futw6bgq.fsf@zancas.localnet> (raw)
In-Reply-To: <m3wpnb0xc6.fsf@zsu.kismala.com>
Istvan Marko <notmuch@kismala.com> writes:
> Regarding tests, I couldn't think of a meaningful test for this. We get
> different behaviors depending on the Xapian version and if we try do
> some kind of a concurrent locking test we'd really be just testing
> Xapian's locking code rather than notmuch.
We would be testing the build/configuration part to make sure we are
enabling the right flags, but more importantly testing the error
handling code, since we have to catch exceptions and pass them back
through the C library interface as error codes. One thing that would
make this easier to test is adding some finer grain errors than
"NOTMUCH_STATUS_XAPIAN_EXCEPTION" for notmuch_database_open_verbose to
return, to distinguish between the case of immediate failure and
timeout. Although it's not clear to me that Xapian actually provides a
timeout when DB_RETRY_LOCK is used.
next prev parent reply other threads:[~2016-05-05 10:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 15:09 [PATCH] Use the Xapian::DB_RETRY_LOCK flag when available Istvan Marko
2016-05-03 16:31 ` Jani Nikula
2016-05-03 19:12 ` [PATCH v2] " Istvan Marko
2016-05-05 10:33 ` David Bremner [this message]
2016-06-04 12:29 ` v3 of DB_RETRY_LOCK David Bremner
2016-06-04 12:29 ` [PATCH 1/4] Use the Xapian::DB_RETRY_LOCK flag when available David Bremner
2016-06-04 12:29 ` [PATCH 2/4] test: factor out some boilerplate from C tests David Bremner
2016-06-04 12:37 ` [PATCH] fixup! " David Bremner
2016-06-14 0:57 ` [PATCH 2/4] " David Bremner
2016-06-04 12:29 ` [PATCH 3/4] test: initial tests for locking retry David Bremner
2016-06-04 12:29 ` [PATCH 4/4] lib: add built_with handling for XAPIAN_DB_RETRY_LOCK David Bremner
2016-06-04 12:38 ` [PATCH] fixup! " David Bremner
2016-05-03 19:01 ` [PATCH] Use the Xapian::DB_RETRY_LOCK flag when available David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87futw6bgq.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@kismala.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).