From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: Re: [Patch v5 06/11] lib: config list iterators
Date: Tue, 24 May 2016 08:54:55 -0300 [thread overview]
Message-ID: <87fut7n01c.fsf@zancas.localnet> (raw)
In-Reply-To: <1463135893-7471-7-git-send-email-david@tethera.net>
David Bremner <david@tethera.net> writes:
> + talloc_set_destructor (list, _notmuch_config_list_destroy);
> + list->iterator = new Xapian::TermIterator;
> + list->notmuch = notmuch;
> + list->current_key = NULL;
> + list->current_val = NULL;
> +
> + try {
> +
> + *list->iterator = notmuch->xapian_db->metadata_keys_begin (CONFIG_PREFIX + (prefix ? prefix : ""));
> +
minimally these two assignments to list->iterator should be right next
to each other, with a comment explaining what the heck. But I think the
following is more idiomatic
- /* force copying onto the heap */
- list->iterator = new Xapian::TermIterator;
- *list->iterator = notmuch->xapian_db->metadata_keys_begin (CONFIG_PREFIX + (prefix ? prefix : ""));
+ list->iterator = new Xapian::TermIterator(notmuch->xapian_db->metadata_keys_begin
+ (CONFIG_PREFIX + (prefix ? prefix : "")));
so that's what I've done in git
next prev parent reply other threads:[~2016-05-24 11:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 10:38 version 5 of libconfig / single argument date / named query patches David Bremner
2016-05-13 10:38 ` [Patch v5 01/11] configure: detect Xapian:FieldProcessor David Bremner
2016-05-13 10:38 ` [Patch v5 02/11] lib: optionally support single argument date: queries David Bremner
2016-05-13 10:38 ` [Patch v5 03/11] lib/cli: add library API / CLI for compile time options David Bremner
2016-05-13 10:38 ` [Patch v5 04/11] configure: check directly for xapian compaction API David Bremner
2016-05-14 0:12 ` David Bremner
2016-05-13 10:38 ` [Patch v5 05/11] lib: provide config API David Bremner
2016-05-24 11:48 ` David Bremner
2016-05-13 10:38 ` [Patch v5 06/11] lib: config list iterators David Bremner
2016-05-24 11:54 ` David Bremner [this message]
2016-05-13 10:38 ` [Patch v5 07/11] CLI: add optional config data to dump output David Bremner
2016-05-13 10:38 ` [Patch v5 08/11] CLI: optionally restore config data David Bremner
2016-05-13 10:38 ` [Patch v5 09/11] CLI: add notmuch-config support for named queries David Bremner
2016-05-13 10:38 ` [Patch v5 10/11] lib: make a global constant for query parser flags David Bremner
2016-05-13 10:38 ` [Patch v5 11/11] lib: add support for named queries David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fut7n01c.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).