From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 0DB216DE02B0 for ; Tue, 30 Aug 2016 04:43:38 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.007 X-Spam-Level: X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=0.004, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kS801k9xr4fd for ; Tue, 30 Aug 2016 04:43:36 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id B7C016DE02AF for ; Tue, 30 Aug 2016 04:43:36 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1behRs-00038m-6P; Tue, 30 Aug 2016 07:43:24 -0400 Received: (nullmailer pid 19151 invoked by uid 1000); Tue, 30 Aug 2016 11:43:25 -0000 From: David Bremner To: Erik Rybakken , Tomi Ollila Cc: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH] Add option `hooks.path` for setting the directory of hooks. In-Reply-To: <20160830084911.4gkpjpzca5jkkcwy@dell> References: <20160824163006.dzdvzjvkg5uxtrnh@dell> <87vayqnjr3.fsf@nikula.org> <20160824215430.ljugc3vevx4ve2gq@dell> <20160827132543.xlqxwu5owhc5x546@dell> <20160830084911.4gkpjpzca5jkkcwy@dell> User-Agent: Notmuch/0.22.1 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 30 Aug 2016 08:43:25 -0300 Message-ID: <87fupmmqhu.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2016 11:43:38 -0000 Erik Rybakken writes: >> >> 1) there is one indentation mismatch ;/ > > I'm not sure what you refer to here. Could you point me to it? I'm not sure either, but a good way to check is % uncrustify [--replace] --config devel/uncrustify.cfg $file Then git diff will tell you what uncrustify found. There are some false positives, usually existing code that's not your fault. d