From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 219A86DE01F7 for ; Mon, 12 Sep 2016 13:03:58 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5GorwnhFvayq for ; Mon, 12 Sep 2016 13:03:57 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTP id 52C5B6DE00BD for ; Mon, 12 Sep 2016 13:03:57 -0700 (PDT) Received: from fifthhorseman.net (unknown [109.112.79.234]) by che.mayfirst.org (Postfix) with ESMTPSA id 95727F993; Mon, 12 Sep 2016 16:03:52 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 83788201E4; Mon, 12 Sep 2016 18:57:20 +0200 (CEST) From: Daniel Kahn Gillmor To: David Bremner , Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: reply: remove wrong sig/enc status buttons In-Reply-To: <877fahq5v3.fsf@zancas.localnet> References: <1473610121-4450-1-git-send-email-markwalters1009@gmail.com> <877fahq5v3.fsf@zancas.localnet> User-Agent: Notmuch/0.22.1+88~g8d09e96 (https://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Mon, 12 Sep 2016 18:57:17 +0200 Message-ID: <87fup5dpjm.fsf@alice.fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2016 20:03:58 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon 2016-09-12 03:11:44 +0200, David Bremner wrote: > Mark Walters writes: > >> This stopps the (usually incorrect) sigstatus and encstatus buttons >> appearing when replying in emacs, and updates the test suite to match. >> >> Overriding the status button functions is a little unusual but much >> less intrusive than passing an argument all the way down the call >> chain. It also makes it clear exactly what it does. >> --- >> >> I dont't have any encrypted messages for testing but it seems to work >> on signed messages (but even that is very lightly tested).=20 > > In replies encrypted messages there is an extra line saying Version: > 1. This is from the first part part of the multipart encrypted > > =E2=94=94=E2=94=AC=E2=95=B4multipart/encrypted 6845 bytes > =E2=94=9C=E2=94=80=E2=95=B4application/pgp-encrypted attachment [PGPMIME= version identification] 11 bytes > =E2=94=94=E2=94=80=E2=95=B4application/octet-stream inline [encrypted.as= c] 2708 bytes > > I'm not really sure it's useful to display in notmuch-show mode > either. If not, that would fix it here also. Perhaps Daniel can comment > on whether it makes sense to just drop it. Yes, it makes no sense to include the "Version: 1" in the quoted/attributed text either. It'd be great to remove that as well. --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJ8BAEBCgBmBQJX1t5tXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRFREIyRTc0RjU2RkNGMkI2NzI5N0I3MzUy NEVDRkY1QUZGNjgzNzBBAAoJECTs/1r/aDcKfRQQAJvP37sJmfpwJDVY2wxq9EIo DFOYf6VtXzMfPDT2aSPJkhBcN2qUctI7bNMO6GMVnFnI0mEYC/U74k//5ozh0usV FdWka7nvMy3qED7gnS6+naFJ31CHJIi44rPVFG4znh3Stgzvwr1Nzucbq8BeLZQw C9A7INCm8l35QripmLWTSN1sRFaEGfNQ/RzsUOJ9VVgELk5KN2pqNd+Ubq74FsPb szcpColgSqZR9RLi95h2zr0jgGefgs7fJevapv8rhpwkxtd33VBd5sTSL6d5MIe4 XshCXOCvaAmSrY6MEuqG086QE6olm54jEUWjredgXexRDanFFk/l2dpqLMgBD5TT vlwCN8jKJzwM5Mbxa4TMSrjDIl47SBtGoJigewVwF+S799znE97+YLsPPdGskGIW NU5GME6KADqb8xTWZfHcblKOFIgFL9HD0vx98AExFOwFzhXAwtpWcSQdqExd2bU0 dU+kSgsNExpxBx8kSgbeWNhap8b5LB1VRRliTJL75ZCQyWEXzgdIBE7Q6/whWNgF T+ykCVZeT7E2UNANcEY+7G/US8JX24kKVMEIAW0KPwTZyEnGc0iXX0i1UwPBuyY1 +KeWnwV1qmg4S8zAf2s6bygc5ILkl9V1nsxkSBTWiAZ243QBk15b1BF30auQw5Ay 5qOQUG/YyoBZc5R4yJVE =ZA0e -----END PGP SIGNATURE----- --=-=-=--