Re: "id buttonization" test failure

[David Bremner <david@tethera.net>]

[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]

David Bremner <david@tethera.net> writes:

>
>
> The following "fixes" this test failure. This suggests to me something
> that only fails when notmuch-show-buttonise-links is called from the C
> redisplay code, and not when it's called from lisp.

The last paragraph of

    https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20146#47

made a lightbulb turn on over my head. I _think_ the problem is that
that fontification expects to be called with the whole message, but jit
lock really doesn't guarantee that.

If you run the attached test with emacs25, you see the list of calls (in tmp.foo/MESSAGES)

fontifying from 1 to 501
fontifying from 1 to 1
fontifying from 62 to 69
fontifying from 494 to 516
fontifying from 187 to 189
fontifying from 195 to 197
fontifying from 198 to 200
fontifying from 210 to 212
fontifying from 214 to 216
fontifying from 226 to 228
fontifying from 230 to 232
fontifying from 586 to 588

and lots more, but the point is many of them are not the whole messages,
which would allow buttons to be created out of partial matches




[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: foo.sh --]
[-- Type: text/x-sh, Size: 1455 bytes --]

#!/usr/bin/env bash

test_description="emacs notmuch-show view"
. ./test-lib.sh || exit 1

EXPECTED=$TEST_DIRECTORY/emacs-show.expected-output

add_email_corpus

test_begin_subtest "id buttonization"
add_message '[body]="
id:abc
id:abc.def. id:abc,def, id:abc;def; id:abc:def:
id:foo@bar.?baz? id:foo@bar!.baz!
(id:foo@bar.baz) [id:foo@bar.baz]
id:foo@bar.baz...
id:2+2=5
id:=_-:/.[]@$%+
id:abc)def
id:ab\"c def
id:\"abc\"def
id:\"ab\"\"c\"def
id:\"ab c\"def
id:\"abc\".def
id:\"abc
\"
id:)
id:
cid:xxx
mid:abc mid:abc/def
mid:abc%20def
mid:abc. mid:abc, mid:abc;"'
test_emacs '(notmuch-show "id:'$gen_msg_id'")
	(notmuch-test-mark-links)
	(test-visible-output "OUTPUT.raw")
	(with-current-buffer "*Messages*"
		  (test-output "MESSAGES"))

'
cat <<EOF >EXPECTED
Notmuch Test Suite <test_suite@notmuchmail.org> (2001-01-05) (inbox)
Subject: id buttonization
To: Notmuch Test Suite <test_suite@notmuchmail.org>
Date: GENERATED_DATE

<<id:abc>>
<<id:abc.def>>. <<id:abc,def>>, <<id:abc;def>>; <<id:abc:def>>:
<<id:foo@bar.?baz>>? <<id:foo@bar!.baz>>!
(<<id:foo@bar.baz>>) [<<id:foo@bar.baz>>]
<<id:foo@bar.baz>>...
<<id:2+2=5>>
<<id:=_-:/.[]@$%+>>
<<id:abc>>)def
<<id:ab"c>> def
<<id:"abc">>def
<<id:"ab""c">>def
<<id:"ab c">>def
<<id:"abc">>.def
id:"abc
"
id:)
id:
cid:xxx
<<mid:abc>> <<mid:abc/def>>
<<mid:abc%20def>>
<<mid:abc>>. <<mid:abc>>, <<mid:abc>>;
EOF
notmuch_date_sanitize < OUTPUT.raw > OUTPUT
test_expect_equal_file OUTPUT EXPECTED

test_done