From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id EFA766DE0AF4 for ; Thu, 20 Oct 2016 09:47:49 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.006 X-Spam-Level: X-Spam-Status: No, score=-0.006 tagged_above=-999 required=5 tests=[AWL=0.005, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wzgm7oO39M0x for ; Thu, 20 Oct 2016 09:47:49 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id CB1496DE0173 for ; Thu, 20 Oct 2016 09:47:48 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1bxGV5-00049A-LJ; Thu, 20 Oct 2016 12:47:27 -0400 Received: (nullmailer pid 16938 invoked by uid 1000); Thu, 20 Oct 2016 16:47:40 -0000 From: David Bremner To: Franz Fellner , Tomi Ollila , notmuch@notmuchmail.org Cc: tomi.ollila@iki.fi Subject: Re: [PATCH] lib/database.cc: fix misleading indentation In-Reply-To: <1.476.968.079-ner-1.779@TP_L520> References: <1474988812-21365-1-git-send-email-tomi.ollila@iki.fi> <1.476.968.079-ner-1.779@TP_L520> Date: Thu, 20 Oct 2016 13:47:40 -0300 Message-ID: <87funrrmqb.fsf@tesseract.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2016 16:47:50 -0000 Franz Fellner writes: > Probably a little bit off-topic, but somewhat related. > There is a wild mix of TABs and spaces used for indenting all over the pl= ace. > I had a hard time to follow the code. Could there be done something? > Do we have some sort of coding style? If not could we agree on some? At l= east > for such important things as indentation... It is possible to use e.g. as= tyle > to apply the formatting automatically. > > Franz from devel/STYLE: * Indent is 4 spaces with mixed tab/spaces and a tab width of 8. (Specifically, a line should begin with zero or more tabs followed by fewer than eight spaces.) that _should_ be enforced by devel/uncrustify.cfg On the other hand, there are also no doubt places in the code where this rule is not adhered to. At the risk of being clich=C3=A9d, whitespace fixup patches are welcome. Finally, it might help to have some settings whatever editor you are using. I'm happy add a file to add a project .vimrc [1] (or whatever editor people are using) to complement the .dir-locals.el that is there. d [1]: all I know about that I read on https://andrew.stwrt.ca/posts/project-= specific-vimrc/