From: David Bremner <david@tethera.net>
To: Franz Fellner <alpine.art.de@gmail.com>,
Tomi Ollila <tomi.ollila@iki.fi>,
notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: Re: [PATCH] lib/database.cc: fix misleading indentation
Date: Thu, 20 Oct 2016 13:47:40 -0300 [thread overview]
Message-ID: <87funrrmqb.fsf@tesseract.cs.unb.ca> (raw)
In-Reply-To: <1.476.968.079-ner-1.779@TP_L520>
Franz Fellner <alpine.art.de@gmail.com> writes:
> Probably a little bit off-topic, but somewhat related.
> There is a wild mix of TABs and spaces used for indenting all over the place.
> I had a hard time to follow the code. Could there be done something?
> Do we have some sort of coding style? If not could we agree on some? At least
> for such important things as indentation... It is possible to use e.g. astyle
> to apply the formatting automatically.
>
> Franz
from devel/STYLE:
* Indent is 4 spaces with mixed tab/spaces and a tab width of 8.
(Specifically, a line should begin with zero or more tabs followed
by fewer than eight spaces.)
that _should_ be enforced by devel/uncrustify.cfg
On the other hand, there are also no doubt places in the code where this
rule is not adhered to. At the risk of being clichéd, whitespace fixup
patches are welcome.
Finally, it might help to have some settings whatever editor you are
using. I'm happy add a file to add a project .vimrc [1] (or whatever editor
people are using) to complement the .dir-locals.el that is there.
d
[1]: all I know about that I read on https://andrew.stwrt.ca/posts/project-specific-vimrc/
next prev parent reply other threads:[~2016-10-20 16:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 15:06 [PATCH] lib/database.cc: fix misleading indentation Tomi Ollila
2016-09-28 11:20 ` David Bremner
2016-10-20 12:54 ` Franz Fellner
2016-10-20 16:47 ` David Bremner [this message]
2016-10-20 18:30 ` Franz Fellner
2016-10-20 23:45 ` David Bremner
2016-10-21 6:42 ` Franz Fellner
2016-10-21 7:01 ` Mark Walters
2016-10-21 13:54 ` editorconfig David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87funrrmqb.fsf@tesseract.cs.unb.ca \
--to=david@tethera.net \
--cc=alpine.art.de@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).