unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* notmuch-0.24.1: missing header include
@ 2017-04-20  9:47 Thomas Klausner
  2017-05-13 22:54 ` David Bremner
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Klausner @ 2017-04-20  9:47 UTC (permalink / raw)
  To: notmuch; +Cc: Jonathan Perkin

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

Hi!

On Solaris, notmuch-0.24.1 does not compile because lib/message.cc
uses index(3) but does not include strings.h.

Please apply the attached patch or a similar one.

Thanks,
 Thomas

[-- Attachment #2: patch-lib_notmuch-private.h --]
[-- Type: text/plain, Size: 392 bytes --]

$NetBSD: patch-lib_notmuch-private.h,v 1.1 2017/04/20 09:06:34 jperkin Exp $

Include strings.h for index(3).

--- lib/notmuch-private.h.orig	2017-04-01 12:29:38.000000000 +0000
+++ lib/notmuch-private.h
@@ -38,6 +38,7 @@ NOTMUCH_BEGIN_DECLS
 #include <sys/stat.h>
 #include <sys/mman.h>
 #include <string.h>
+#include <strings.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <unistd.h>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: notmuch-0.24.1: missing header include
  2017-04-20  9:47 notmuch-0.24.1: missing header include Thomas Klausner
@ 2017-05-13 22:54 ` David Bremner
  2017-05-14 10:08   ` Thomas Klausner
  0 siblings, 1 reply; 3+ messages in thread
From: David Bremner @ 2017-05-13 22:54 UTC (permalink / raw)
  To: Thomas Klausner, notmuch; +Cc: Jonathan Perkin, notmuch

Thomas Klausner <tk@giga.or.at> writes:

> Hi!
>
> On Solaris, notmuch-0.24.1 does not compile because lib/message.cc
> uses index(3) but does not include strings.h.
>
> Please apply the attached patch or a similar one.
>
> Thanks,
>  Thomas

In master we've replaced index(3) with strchr(3). Does that fix your
issue, or is the include still needed?

d

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: notmuch-0.24.1: missing header include
  2017-05-13 22:54 ` David Bremner
@ 2017-05-14 10:08   ` Thomas Klausner
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Klausner @ 2017-05-14 10:08 UTC (permalink / raw)
  To: David Bremner; +Cc: notmuch, Jonathan Perkin, notmuch

On Sat, May 13, 2017 at 07:54:39PM -0300, David Bremner wrote:
> > On Solaris, notmuch-0.24.1 does not compile because lib/message.cc
> > uses index(3) but does not include strings.h.
> >
> > Please apply the attached patch or a similar one.
> >
> > Thanks,
> >  Thomas
> 
> In master we've replaced index(3) with strchr(3). Does that fix your
> issue, or is the include still needed?

Since you already include <string.h> that's fine.

Thanks,
 Thomas

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-14 10:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-20  9:47 notmuch-0.24.1: missing header include Thomas Klausner
2017-05-13 22:54 ` David Bremner
2017-05-14 10:08   ` Thomas Klausner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).