From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 5C4AD6DE023B
 for <notmuch@notmuchmail.org>; Tue, 24 Apr 2018 18:52:31 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.011,
 SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id XC0wyxstA5t9 for <notmuch@notmuchmail.org>;
 Tue, 24 Apr 2018 18:52:29 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id 78E036DE0238
 for <notmuch@notmuchmail.org>; Tue, 24 Apr 2018 18:52:29 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.89)
 (envelope-from <david@tethera.net>)
 id 1fB9bc-0007LU-DV; Tue, 24 Apr 2018 21:52:24 -0400
Received: (nullmailer pid 2033 invoked by uid 1000);
 Wed, 25 Apr 2018 01:52:23 -0000
From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH 6/6] lib: choose oldest message when breaking reference
 loops
In-Reply-To: <m2bmeccuo9.fsf@guru.guru-group.fi>
References: <20180414014610.15438-6-david@tethera.net>
 <20180420183135.14331-1-david@tethera.net>
 <20180420183135.14331-7-david@tethera.net>
 <m2bmeccuo9.fsf@guru.guru-group.fi>
Date: Tue, 24 Apr 2018 22:52:23 -0300
Message-ID: <87fu3kkq7c.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Apr 2018 01:52:31 -0000

Tomi Ollila <tomi.ollila@iki.fi> writes:

> Otherwise the series _looks_ good do me. The thing that disturbs me are
> these `strlen (in_reply_to)` contents. Perhaps SomeOne(TM) changes these
> to e.g. in_reply_to[0] in the future...
>

That same file defines and uses an EMPTY_STRING macro. We should
probably be consistent, either use that macro everywehre or
nowhere. Perhaps move it to lib/notmuch-private.h?

d