From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id EE8266DE12BD for ; Sun, 26 May 2019 09:54:28 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.042 X-Spam-Level: X-Spam-Status: No, score=-0.042 tagged_above=-999 required=5 tests=[AWL=-0.041, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fMp5Dv0VBA7v for ; Sun, 26 May 2019 09:54:28 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id D68616DE0F9E for ; Sun, 26 May 2019 09:54:27 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1hUwPi-0005uN-CJ; Sun, 26 May 2019 12:54:26 -0400 Received: (nullmailer pid 1996 invoked by uid 1000); Sun, 26 May 2019 16:54:29 -0000 From: David Bremner To: Daniel Kahn Gillmor , Notmuch Mail Subject: Re: revision 3: easing access to the cryptographic envelope In-Reply-To: <87tvdh45kc.fsf@fifthhorseman.net> References: <20190525180406.30965-1-dkg@fifthhorseman.net> <87zhn9l905.fsf@tethera.net> <87tvdh45kc.fsf@fifthhorseman.net> Date: Sun, 26 May 2019 13:54:29 -0300 Message-ID: <87ftp1kvga.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 May 2019 16:54:29 -0000 Daniel Kahn Gillmor writes: > On Sun 2019-05-26 09:01:46 -0300, David Bremner wrote: >> Daniel Kahn Gillmor writes: >> >>> This is the third revision of the series originally posted at >>> id:20190424183113.29242-1-dkg@fifthhorseman.net (revision 2 was at >>> id:20190520032228.27420-1-dkg@fifthhorseman.net) >>> >>> This series addresses comments raised by David Bremner in his review. >>> Thanks, Bremner! >> >> I pushed this version, with 4 minor whitespace fixups (inserted spaces >> and/or deleted blank lines) that I missed in my previous review. > > Thanks for these fixes, Bremner. If you have a specific set of tooling > that you use that i can adopt to catch those kinds of coding convention > mishaps before submitting, i'd be happy to adopt it so things are > "clean". Bonus points if it integrates into emacs via .dir-locals.el or > something :P To be honest my main mechanism for catching those problems is Tomi ;). There is also a reasonable uncrustify configuration that I don't use as often as I should, mainly because the baseline in various files is not there. Perhaps if we did more some global whitespace cleanup this would be more helpful. To try it out run % uncrustify -c devel/uncrustify.cfg --replace $files then % git diff to see what changed. % find -name .git -prune -o -type f -a -regex '.*[.]\(c\|h\|cc\)' -print -exec uncrustify -c devel/uncrustify.cfg --replace {} \; yields a whopping 1933 insertions and 1903 deletions. Perhaps there are some places where the uncrustify config needs tuning, but none of the output looked crazy to me. Two things I noticed causing lots of changes 1) "!foo" -> "! foo" 2) putting a leading * in front of multi-line comments If we do decide to rip off the bandage, that will cause a certain amount of rebasing pain for any patch series in flight; now (i.e after the release) is actually a pretty good time from my point of view, but others (e.g. you) might feel differently.