From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 7E4896DE1452 for ; Tue, 25 Jun 2019 11:10:32 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.565 X-Spam-Level: X-Spam-Status: No, score=-0.565 tagged_above=-999 required=5 tests=[AWL=0.336, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pBWhAC9OTysO for ; Tue, 25 Jun 2019 11:10:32 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id D09CC6DE1499 for ; Tue, 25 Jun 2019 11:10:31 -0700 (PDT) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1561486231; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=p7FkaoAqqsG6PUl9IINgd47MPXRvSHf0pJNpopWA0zU=; b=8ahKp4Z403YAfML7i54/l4wGS3c6XK1bMdQ1NTTv/6Mwid9A5voa+0C2 FaLQSF8OLGj5Fm0VREELR1lwlmquBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1561486230; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=p7FkaoAqqsG6PUl9IINgd47MPXRvSHf0pJNpopWA0zU=; b=RhtV7SRZb5rxHG9GHtjd8cwgDWtdBMPa4+j0CHFQ+SWNYhYS1qSIQpNB dLd7drPQSY2XrCyIru3QZoXupKh9OTpAuk9FtQbnTfbE7LUrZKNgG4yT7+ iqpCcQPuNixCXkoenYylVdDFoNuXVINVLKKE6m6aR/KmpEQMOuUk3cgOvR 7/smb7a5FpM+o5a72Hducj/Pc0ldBA13mdYffBBtHW+6iinG3Spwx+dni2 hgoxxRz2mDFPSs/fcVr5lNyfQul+EkamrEMjkJJDJCTREegPiuqzWRIfTj iyqxX8109jA6pcYawCxBmw5TE9vzxDey70JJfG2n+qloJXV2m6Lzag== Received: from fifthhorseman.net (unknown [38.109.115.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id C4474F99E; Tue, 25 Jun 2019 14:10:30 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id C074B20437; Tue, 25 Jun 2019 13:59:29 -0400 (EDT) From: Daniel Kahn Gillmor To: William Casarin , Notmuch Mail Subject: Re: [PATCH 1/7] mime-node: split out _mime_node_set_up_part In-Reply-To: <877e9amljl.fsf@jb55.com> References: <20190625014107.12452-1-dkg@fifthhorseman.net> <20190625014107.12452-2-dkg@fifthhorseman.net> <877e9amljl.fsf@jb55.com> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEXEK/AhYJKwYBBAHaRw8BAQdAr/gSROcn+6m8ijTN0DV9AahoHGafy52RRkhCZVwxhEe0K0Rh bmllbCBLYWhuIEdpbGxtb3IgPGRrZ0BmaWZ0aGhvcnNlbWFuLm5ldD6ImQQTFggAQQIbAQUJA8Jn AAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBMS8Lds4zOlkhevpwvIGkReQOOXGBQJcQsbzAhkB AAoJEPIGkReQOOXG4fkBAO1joRxqAZY57PjdzGieXLpluk9RkWa3ufkt3YUVEpH/AP9c+pgIxtyW +FwMQRjlqljuj8amdN4zuEqaCy4hhz/1DbgzBFxCv4sWCSsGAQQB2kcPAQEHQERSZxSPmgtdw6nN u7uxY7bzb9TnPrGAOp9kClBLRwGfiPUEGBYIACYWIQTEvC3bOMzpZIXr6cLyBpEXkDjlxgUCXEK/ iwIbAgUJAeEzgACBCRDyBpEXkDjlxnYgBBkWCAAdFiEEyQ5tNiAKG5IqFQnndhgZZSmuX/gFAlxC v4sACgkQdhgZZSmuX/iVWgD/fCU4ONzgy8w8UCHGmrmIZfDvdhg512NIBfx+Mz9ls5kA/Rq97vz4 z48MFuBdCuu0W/fVqVjnY7LN5n+CQJwGC0MIA7QA/RyY7Sz2gFIOcrns0RpoHr+3WI+won3xCD8+ sVXSHZvCAP98HCjDnw/b0lGuCR7coTXKLIM44/LFWgXAdZjm1wjODbg4BFxCv50SCisGAQQBl1UB BQEBB0BG4iXnHX/fs35NWKMWQTQoRI7oiAUt0wJHFFJbomxXbAMBCAeIfgQYFggAJhYhBMS8Lds4 zOlkhevpwvIGkReQOOXGBQJcQr+dAhsMBQkB4TOAAAoJEPIGkReQOOXGe/cBAPlek5d9xzcXUn/D kY6jKmxe26CTws3ZkbK6Aa5Ey/qKAP0VuPQSCRxA7RKfcB/XrEphfUFkraL06Xn/xGwJ+D0hCw== Date: Tue, 25 Jun 2019 13:59:29 -0400 Message-ID: <87ftnxv94u.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jun 2019 18:10:32 -0000 --=-=-= Content-Type: text/plain On Mon 2019-06-24 19:43:58 -0700, William Casarin wrote: >> +static bool >> +_mime_node_set_up_part (mime_node_t *node, GMimeObject *part, int numchild); >> + > > nit: Instead of a forward declaration, could _mime_node_create be moved after > _mime_node_set_up_part instead? yep, we could definitely do that. I did it this way because the diff feels cleaner to me -- rather than moving a big chunk of code, i'm just breaking one function in half. If anyone feels strongly about it, i wouldn't object to doing it the other way around, but i'd be unlikely to want to rerun the patch series for this change on its own. --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQTJDm02IAobkioVCed2GBllKa5f+AUCXRJhAQAKCRB2GBllKa5f +HnxAP9sEMYIrEb14Sc1PnZ1pn5Zkwp1CnQFMpsMz/s1kiT/LAEAw92UuZ++oc8J nj42GrsyZDsXbkZlnx+697Ql5em1MgU= =sMuM -----END PGP SIGNATURE----- --=-=-=--