From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: William Casarin <jb55@jb55.com>, Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 1/7] mime-node: split out _mime_node_set_up_part
Date: Tue, 25 Jun 2019 13:59:29 -0400 [thread overview]
Message-ID: <87ftnxv94u.fsf@fifthhorseman.net> (raw)
In-Reply-To: <877e9amljl.fsf@jb55.com>
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
On Mon 2019-06-24 19:43:58 -0700, William Casarin wrote:
>> +static bool
>> +_mime_node_set_up_part (mime_node_t *node, GMimeObject *part, int numchild);
>> +
>
> nit: Instead of a forward declaration, could _mime_node_create be moved after
> _mime_node_set_up_part instead?
yep, we could definitely do that. I did it this way because the diff
feels cleaner to me -- rather than moving a big chunk of code, i'm just
breaking one function in half.
If anyone feels strongly about it, i wouldn't object to doing it the
other way around, but i'd be unlikely to want to rerun the patch series
for this change on its own.
--dkg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2019-06-25 18:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 1:41 v3 of legacy-display cleanup Daniel Kahn Gillmor
2019-06-25 1:41 ` [PATCH 1/7] mime-node: split out _mime_node_set_up_part Daniel Kahn Gillmor
2019-06-25 2:43 ` William Casarin
2019-06-25 17:59 ` Daniel Kahn Gillmor [this message]
2019-06-25 1:41 ` [PATCH 2/7] repair: set up codebase for repair functionality Daniel Kahn Gillmor
2019-06-25 1:41 ` [PATCH 3/7] test: avoid showing legacy-display parts Daniel Kahn Gillmor
2019-06-25 1:41 ` [PATCH 4/7] util/crypto: _n_m_crypto_potential_payload returns whether part is the payload Daniel Kahn Gillmor
2019-07-31 11:57 ` David Bremner
2019-08-01 3:15 ` Daniel Kahn Gillmor
2019-08-01 3:29 ` Daniel Kahn Gillmor
2019-08-01 11:32 ` David Bremner
2019-08-01 14:10 ` Daniel Kahn Gillmor
2019-08-01 11:33 ` David Bremner
2019-06-25 1:41 ` [PATCH 5/7] util/repair: add _notmuch_repair_crypto_payload_skip_legacy_display Daniel Kahn Gillmor
2019-06-25 3:02 ` William Casarin
2019-06-25 18:10 ` Daniel Kahn Gillmor
2019-08-03 15:15 ` David Bremner
2019-08-06 13:08 ` Daniel Kahn Gillmor
2019-06-25 1:41 ` [PATCH 6/7] cli/{show,reply}: skip over legacy-display parts Daniel Kahn Gillmor
2019-06-25 1:41 ` [PATCH 7/7] index: avoid indexing " Daniel Kahn Gillmor
2019-06-25 3:06 ` v3 of legacy-display cleanup William Casarin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftnxv94u.fsf@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=jb55@jb55.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).